Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure okhttp is not a transitive dependency for both tracing-zipkin and when using Open Telemetry zipkin exporter #203

Open
graemerocher opened this issue Nov 9, 2022 · 0 comments
Open

Ensure okhttp is not a transitive dependency for both tracing-zipkin and when using Open Telemetry zipkin exporter #203

graemerocher opened this issue Nov 9, 2022 · 0 comments
Assignees
@n0tl3ss
Labels
type: improvement A minor improvement to an existing feature

Comments

@graemerocher
Copy link
Contributor

Feature description

When using the Open Telemetry Zipkin exporter okhttp is a transitive dependency to provide the sender. This should be unnecessary as we have our own sender implementation. See https://github.com/micronaut-projects/micronaut-tracing/blob/master/tracing-zipkin/src/main/java/io/micronaut/tracing/brave/sender/HttpClientSender.java

okhttp should be excluded from the transitive dependency graph.

We may need a specific opentelemetry-zipkin module for this.
@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n0tl3ss n0tl3ss

Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graemerocher @n0tl3ss