Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP guide for Google Functions doesn't correctly declares Maven dependencies #491

Open
Praytic opened this issue Sep 20, 2021 · 0 comments
Assignees

Comments

@Praytic
Copy link

Praytic commented Sep 20, 2021

Expected Behavior

Dependency for Netty server should be provided

<dependency>
    <groupId>io.micronaut</groupId>
    <artifactId>micronaut-http-server-netty</artifactId>
    <scope>provided</scope>
</dependency>

...and excluded from tests

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-surefire-plugin</artifactId>
    <configuration>
        <classpathDependencyExcludes>
            <classpathDependencyExclude>io.micronaut:micronaut-http-server-netty</classpathDependencyExclude>
        </classpathDependencyExcludes>
    </configuration>
</plugin>

Actual Behaviour

Netty dependency has invalid scope.

<dependency>
    <groupId>io.micronaut</groupId>
    <artifactId>micronaut-http-server-netty</artifactId>
    <scope>developmentOnly</scope>
</dependency>

Steps To Reproduce

Create a sample app with CLI:

mn create-app demo -b maven -f google-cloud-function

Proceed with instructions from https://micronaut-projects.github.io/micronaut-gcp/4.0.0/guide/index.html#httpFunctions.

Environment Information

No response

Example Application

No response

Version

4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants