Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to login/order requests #15

Open
zendern opened this issue May 17, 2020 · 0 comments
Open

Add retries to login/order requests #15

zendern opened this issue May 17, 2020 · 0 comments
Labels
type: enhancement New feature or request

Comments

@zendern
Copy link
Collaborator

zendern commented May 17, 2020

See PR #14

Both these calls have no retry attempts....probably not a bad idea to add them like we do for authorizations.

private Order createOrder(List<String> domains, Login login) throws AcmeException {
Order order = login.getAccount()
.newOrder()
.domains(domains)
.create();
return order;
}
private Login doLogin(Session session, KeyPair accountKeyPair) throws AcmeException {
Login login = new AccountBuilder()
.onlyExisting()
.useKeyPair(accountKeyPair)
.createLogin(session);
return login;
}

@alvarosanchez alvarosanchez added the type: enhancement New feature or request label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants