Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Num-keys with modifier doesn't work for transmit on additional channel. #1258

Closed
Pergor opened this issue May 13, 2017 · 10 comments
Closed
Assignees
Labels
Milestone

Comments

@Pergor
Copy link

Pergor commented May 13, 2017

Arma 3 Version: 1.68
CBA Version: 3.3.1.170504
Task Force Radio Version: 1.1.0.235

Mods:

  • @CBA_A3
  • @task_force_radio

Description:
I happen to have transmitting my radios on Num-5 (SR) and Num-8 (LR) - before you wonder, I'm using a Logitech G600 with loads of buttons which are mapped to Num-keys. Before .235 I had the additional transmit mapped to Ctrl-Num-5 and Ctrl-Num-8 respectively. That doesn't work anymore.
Ctrl-Num-5 for regular transmit works fine, just not for the additional channel.
I'm not sure if this is a genuine TFAR problem or a CBA problem though.

Steps to reproduce:
Set your controls for SW Transmit Additional to Ctrl-Num-5 and try to transmit -> result is: it doesn't work.
Set your controls for SW Transmit to Ctrl-Num-5 and try to transmit -> result is: it does work.

@dedmen dedmen self-assigned this May 13, 2017
@dedmen
Copy link
Collaborator

dedmen commented May 13, 2017

If it works for Transmit and not for additonal then that's not a CBA problem.. Have to look at that.

@dedmen dedmen added the bug label May 13, 2017
@Pergor
Copy link
Author

Pergor commented May 14, 2017

If you need additional information, I'm happy to help.

@Fusselwurm
Copy link

Looks like a problem I have (last tested with 261) – using modifiers wont work for transmitting additional.

@dedmen
Copy link
Collaborator

dedmen commented Oct 3, 2017


okay, so it seems to me that I will transmit on "normal" instead of "additional" channel, if the "additional" shortcut is a modified version of the "normal" one…
in this example, I will be able to transmit LR additional when using Shift+P, but when using Shift+ü then just the normal LR transmit will happen

@dedmen dedmen added this to the 1.0 milestone Oct 3, 2017
@commy2
Copy link
Contributor

commy2 commented Apr 17, 2019

Should be fixed after CBATeam/CBA_A3#686, pls test.

@Pergor
Copy link
Author

Pergor commented Apr 17, 2019

As of CBA-version 3.10.1.190316 and TFAR version 1.0.312 the problem still persists.

@dedmen
Copy link
Collaborator

dedmen commented Apr 18, 2019

https://github.com/michail-nikolaev/task-force-arma-3-radio/tree/1.0/addons/core/functions/events/keys
Cause is likely somewhere in the onAdditional
Or in
https://github.com/michail-nikolaev/task-force-arma-3-radio/blob/1.0/addons/core/functions/events/keys/fnc_onTangentPressedHack.sqf
Which is specifically aimed to trigger radios with modifiers pressed.

So if you have transmit on T, and alt transmit on shift+T
That code will fire, and ignore the modifier key, and see that you are pressing T which is non-alt transmit.

Frankly it's a bit of a mess. Frankly don't really understand it right now either. It was taken over from 0.9

@commy2
Copy link
Contributor

commy2 commented Apr 18, 2019

Then nuke this hack and use my improved key handling, which was made after this hack.

@dedmen
Copy link
Collaborator

dedmen commented Oct 3, 2019

Yes cause was in hack.
Hack is still needed for sprinting.

Seems 994c33f fixed this too.
Tested with CTRL+Numpad 5 as second keybinding for LR Additional.
Works fine when pressing SHIFT+CTRL+NUM5, but not SHIFT+CTRL+W+NUM5 but I think that's my keyboards or armas problem, not the script.

Now I just gotta find out why SW Transmit bind on CTRL+NUM5 also activates LR in my test env... Frick

@dedmen
Copy link
Collaborator

dedmen commented Oct 3, 2019

Derp, it doesn't. CTRL+NUM5 is just the channel switch key for LR

@dedmen dedmen closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants