Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example on side nav patterns page goes against guidance #1243

Open
ad9242 opened this issue Dec 4, 2024 · 0 comments
Open

Example on side nav patterns page goes against guidance #1243

ad9242 opened this issue Dec 4, 2024 · 0 comments
Labels
type: bug 🐛 An unexpected problem or unintended behaviour
Milestone
PI 10 V3

Comments

@ad9242
Copy link
Contributor

ad9242 commented Dec 4, 2024

Summary of the bug

The image on the following page does not adhere to the guidance:
https://design.sis.gov.uk/patterns/navigation-patterns/side-navigation-layout#customisation

In the guidnace (https://design.sis.gov.uk/patterns/navigation-patterns/side-navigation-layout#customisation) it says:
"Don't position the side navigation so that it does not vertically fill the browser window."

🧐 Expected behaviour

The images should be updated to show a correct layout
@ad9242 ad9242 added the type: bug 🐛 An unexpected problem or unintended behaviour label Dec 4, 2024
@MI6-255 MI6-255 added this to the PI 10 V3 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug 🐛 An unexpected problem or unintended behaviour
Projects
Intelligence Community Design System
Status: Design to-do
Milestone
PI 10 V3
Development

No branches or pull requests
2 participants
@MI6-255 @ad9242