Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icds-pages-data.json from source control #1234

Open
GCHQ-Developer-741 opened this issue Dec 3, 2024 · 0 comments
Open

Remove icds-pages-data.json from source control #1234

GCHQ-Developer-741 opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels
dx Related to developers' experience
Milestone

Comments

@GCHQ-Developer-741
Copy link
Contributor

Summary

Originally, the icds-pages-data.json was added as part of an internal issue #349 , where it is kept in the public directory so it can be accessed via an endpoint on our site. However, this file has contributed to countless merge conflict issues due to it formatting certain things differently on people's machines, only to then be pushed up when updates are made to page content.

💬 Description

Is it possible to remove the file from source control, and have it perhaps generated on the CI and served up to users on the live site? Am aware it is used by the component gallery, however should still be possible to generate a local copy for testing, and having the deployed version use the copy held in the public directory.

Why do we need it?

Would prevent future merge conflicts from occurring when there are no actual clashes between changes, speeding up productivity and also reducing space taken by files in our repository.

@GCHQ-Developer-741 GCHQ-Developer-741 added the dx Related to developers' experience label Dec 3, 2024
@GCHQ-Developer-741 GCHQ-Developer-741 changed the title Prevent icds-pages-data.json from being committed to GitHub Remove icds-pages-data.json from source control Dec 3, 2024
@ad9242 ad9242 added this to the PI 11 V3 milestone Dec 4, 2024
@GCHQ-Developer-741 GCHQ-Developer-741 self-assigned this Dec 6, 2024
@GCHQ-Developer-741 GCHQ-Developer-741 moved this from In Refinement to In Review in Intelligence Community Design System Dec 6, 2024
@GCHQ-Developer-741 GCHQ-Developer-741 linked a pull request Dec 6, 2024 that will close this issue
2 tasks
@GCHQ-Developer-741 GCHQ-Developer-741 moved this from In Review to Dev In Progress in Intelligence Community Design System Jan 30, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 removed a link to a pull request Jan 30, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Related to developers' experience
Projects
Status: Dev In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants