Deletion of digest doesn't work from admin UI

[amitsaxena]

Describe the bug
When I try to delete a digest from sidekiq dashboard under unique digests tab, nothing happens and the digest stays. I am talking about this interface:

The digests I was trying to delete were some stuck locks preventing further jobs from being scheduled. I eventually had to delete the keys manually from redis.

I am using sidekiq-unique-jobs version 6.0.13

Expected behavior
The digest should be deleted and disappear from that page

Current behavior
The digest isn't deleted and stays on the page and the keys are still present in redis

[mhenrixon]

Super weird, are you using rails, sinatra, rack, grape? How do you run sidekiq web?

[amitsaxena]

I am using Rails 5.2.2.1. We mount it as per the standard recommendation:

require "sidekiq/pro/web"
require "sidekiq_unique_jobs/web"
mount Sidekiq::Web => "/sidekiq"

The page shows up fine and clicking the Delete button sends a request and the page is refreshed. Just that the digest isn't deleted and stays on the page.

[amitsaxena]

I am not sure if it's related, but I also see warnings like this:

[13] pry(main)> SidekiqUniqueJobs::Digests.del(digest: "5afaacdbee7148e90cea3c15de700f21")
Passing 'script' command to redis as is; administrative commands cannot be effectively namespaced and should be called on the redis connection directly; passthrough has been deprecated and will be removed in redis-namespace 2.0 (at /Users/amit/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/sidekiq-unique-jobs-6.0.15/lib/sidekiq_unique_jobs/scripts.rb:73:in `script_sha')
2019-11-20T14:44:56.252Z pid=79457 tid=oxqpmk67d INFO: delete_by_digest(5afaacdbee7148e90cea3c15de700f21) completed in 0.02ms
=> 1

[mhenrixon]

Will be released as v6.0.17 shortly

[mhenrixon]

Released a fix as v6.0.17

[amitsaxena]

This doesn't seem to be fixed for us. We are currently on version 6.0.18.

[mhenrixon]

Do you still have the same warnings in your logs @amitsaxena?

[amitsaxena]

@mhenrixon Yes I still see the same warning.

[mhenrixon]

@amitsaxena the problem is with redis-namespace preventing this. The way sidekiq wires up redis-namespace prevents this gem from working properly. If you have any suggestions I'm all ears but currently my commands won't work because I can't use redis-namespace with lua scripts and the gem is all about lua scripts.

[mhenrixon]

This is documented here https://github.com/resque/redis-namespace#administrative-commands and I see no way to fix this in an easy way. I would have to manually namespace the keys somehow and I'm not sure I want to support that.

Mike Perham recommended strongly against using redis-namespace already back in 2015 https://www.mikeperham.com/2015/09/24/storing-data-with-redis/ and then went on to provide a migration solution towards not using it in https://www.mikeperham.com/2017/04/10/migrating-from-redis-namespace/.

I imagine he recommends against it for a reason (sidekiq-pro sidekiq-ent relies on Lua scripts to do the heavy lifting). Sorry about that.

[mhenrixon]

Closing due to limitations in redis-namespace.