From 6228ba57cff6a007626cbda35f9dfb1249950a47 Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Mon, 4 Nov 2024 14:25:03 +0200 Subject: [PATCH] refactor: simplify tests (#1089) --- revivelib/core_internal_test.go | 2 +- test/utils_test.go | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/revivelib/core_internal_test.go b/revivelib/core_internal_test.go index ea1f779a3..a6dcd846a 100644 --- a/revivelib/core_internal_test.go +++ b/revivelib/core_internal_test.go @@ -18,7 +18,7 @@ func TestReviveCreateInstance(t *testing.T) { t.Fatal("Expected MaxOpenFiles to be 2048") } - if revive.lintingRules == nil || len(revive.lintingRules) == 0 { + if len(revive.lintingRules) == 0 { t.Fatal("Linting rules not loaded.") } diff --git a/test/utils_test.go b/test/utils_test.go index 7cc5f2560..c6270dbe6 100644 --- a/test/utils_test.go +++ b/test/utils_test.go @@ -40,9 +40,7 @@ func testRule(t *testing.T, filename string, rule lint.Rule, config ...*lint.Rul } func assertSuccess(t *testing.T, baseDir string, fi os.FileInfo, rules []lint.Rule, config map[string]lint.RuleConfig) error { - l := lint.New(func(file string) ([]byte, error) { - return os.ReadFile(file) - }, 0) + l := lint.New(os.ReadFile, 0) filePath := filepath.Join(baseDir, fi.Name()) ps, err := l.Lint([][]string{{filePath}}, rules, lint.Config{ @@ -63,9 +61,7 @@ func assertSuccess(t *testing.T, baseDir string, fi os.FileInfo, rules []lint.Ru } func assertFailures(t *testing.T, baseDir string, fi os.FileInfo, src []byte, rules []lint.Rule, config map[string]lint.RuleConfig) error { - l := lint.New(func(file string) ([]byte, error) { - return os.ReadFile(file) - }, 0) + l := lint.New(os.ReadFile, 0) ins := parseInstructions(t, filepath.Join(baseDir, fi.Name()), src) if ins == nil {