Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export NgWalker for library users #657

Closed
piyukore06 opened this issue Jun 2, 2018 · 2 comments
Closed

export NgWalker for library users #657

piyukore06 opened this issue Jun 2, 2018 · 2 comments

Comments

@piyukore06
Copy link
Contributor

Hello Maintainers,

Thank you for building Codelyzer. It is really helpful not just for catching lint errors but also knowing what is a good way of doing a certain thing.

TsLint has exported it's Walkers. On top of which devs can build custom TsLint rules. I wanted to build a custom rule using angular metadata but I found out that NgWalker is not exported.

Is there any particular reason it was not exported?
I am really new at this so if there is any other way of doing the same, pls let me know.

@mgechev
Copy link
Owner

mgechev commented Jun 2, 2018

Hey @piyukore06, I've thought of externalizing the NgWalker several times. Your proposal makes a lot of sense. To prioritize this feature request, I'll add votes needed label and close it, so that people can vote and we can introduce it as part of the roadmap if the demand is high. Alternatively, if you have some time, we'd love to get a PR from you!

@rafaelss95
Copy link
Collaborator

rafaelss95 commented Feb 16, 2019

@mgechev Let's remove the votes needed label from issues that have already been finalized? It's a little confusing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants