-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop selector validators compatible with spec #15
Comments
During the last meeting, we decided to use the For instance, for const selector = CssSelector.parse(component.selector);
if (selector.element !== null) {
// validate if it is a valid kebab-case elector, if not, throw a warning
} else {
// throw a warning that the component doesn’t use element selector
} Problem that needs to be considered if a mixture is used (i.e. component with element and attribute/class selector, etc.). We need to make sure we're aligned with the style guide. |
#137 Needs reviewing |
Fixed by 3373dff. |
Currently the selectors' validators are not compatible with spec.
The text was updated successfully, but these errors were encountered: