Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using overrides without specifying a footer, footer theme is set to default #51

Closed
rmartine-ias opened this issue Nov 20, 2023 · 1 comment · Fixed by #52
Closed

Comments

@rmartine-ias
Copy link
Contributor

When presenting a file with overrides set, the lack of a footer key is interpreted as an empty footer, which is parsed as the default footer, which overrides the theme's footer.

Reproduction:

  1. presenterm examples/demo.md (see progress bar)
  2. Edit header of demo.md to include:
    theme:
     override:
       default:
  3. presenterm examples/demo.md (see 1/9 in footer)
@mfontanini
Copy link
Owner

Thanks for the report! This should be fixed now, but let me know otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants