Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.yaml file is ignored on Windows #180

Closed
nagromc opened this issue Jan 29, 2024 · 4 comments · Fixed by #181
Closed

config.yaml file is ignored on Windows #180

nagromc opened this issue Jan 29, 2024 · 4 comments · Fixed by #181

Comments

@nagromc
Copy link
Contributor

nagromc commented Jan 29, 2024

The config.yaml file is ignored on Windows unless I set the HOME environment variable to %USERPROFILE%. %APPDATA% should be preferred on Windows though.

Using the directories crate may help to load platform-specific paths (%APPDATA% on Windows for example).

presenterm v0.5.0

@mfontanini
Copy link
Owner

What's the exact path you would expect it to be in Windows? %APPDATA%/presenterm/config.yaml?

@nagromc
Copy link
Contributor Author

nagromc commented Jan 29, 2024

Well, it’s up to your implementation, actually.

I think we should respect platform-specific paths:

  • on Windows: %APPDATA%/presenterm/config.yaml (will point to %USERPROFILE%/AppData/Roaming/presenterm/config.yaml)
  • on Linux: ~/.config/presenterm/config.yaml
  • on macOS: ~/Library/notSureOfThisPart/presenterm/config.yaml

Or, if you want to keep it simple, ~/.config/presenterm/config.yaml on every platform.

@mfontanini
Copy link
Owner

Thanks for the report! I verified this works as expected in windows (see PR for paths) but feel free to double check.

@nagromc
Copy link
Contributor Author

nagromc commented Jan 30, 2024

It works as expected on Windows on my side. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants