Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update library to support mysqlclient>=1.4.0 #18

Closed
arikfr opened this issue Sep 19, 2019 · 2 comments
Closed

Update library to support mysqlclient>=1.4.0 #18

arikfr opened this issue Sep 19, 2019 · 2 comments

Comments

@arikfr
Copy link

arikfr commented Sep 19, 2019

In version 1.4.0 of mysqlclient they moved the _mysql module into the MySQLdb package (PyMySQL/mysqlclient#293).

Will you be interested in accepting a pull request that adds support for this version of mysqlclient? It can be done in a backward compatible way:

try:
    import _mysql
except ImportError:
    from MySQLdb import _mysql
@arikfr
Copy link
Author

arikfr commented Sep 22, 2019

It looks like it will require an update in memsql.common.conversions as well, as the current code assumes converters are arrays.

@arikfr arikfr mentioned this issue Sep 22, 2019
Closed
@carlsverre
Copy link
Contributor

Sorry for the huge delay on this - please check it out and let me know if you run into any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arikfr @carlsverre