From 6d89d02f98bc2158d420d2ff9e6890a4c3ef0e5e Mon Sep 17 00:00:00 2001 From: Haleemur Ali Date: Thu, 1 Aug 2024 12:08:59 -0400 Subject: [PATCH] compile create column clause with sqla engine to ensure proper quoting is applied --- singer_sdk/connectors/sql.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/singer_sdk/connectors/sql.py b/singer_sdk/connectors/sql.py index 4d2dd4842..e9456bc27 100644 --- a/singer_sdk/connectors/sql.py +++ b/singer_sdk/connectors/sql.py @@ -974,8 +974,8 @@ def _get_column_type( return column.type - @staticmethod def get_column_add_ddl( + self, table_name: str, column_name: str, column_type: sa.types.TypeEngine, @@ -998,11 +998,12 @@ def get_column_add_ddl( column_type, ), ) + compiled = create_column_clause.compile(self._engine) return sa.DDL( "ALTER TABLE %(table_name)s ADD COLUMN %(create_column_clause)s", - { + { # type: ignore[arg-type] "table_name": table_name, - "create_column_clause": create_column_clause, + "create_column_clause": compiled, }, )