-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Test workflow does not fail for unsupported Python versions #2223
Comments
Thanks for logging @ReubenFrankel. I'm not sure if Poetry has a config that'd help with this, or if the solution is not using Poetry in the cookiecutter's included test workflow... |
@edgarrmondragon I think this might be possible to do with - name: Install dependencies
run: |
poetry env use ${{ matrix.python-version }}
poetry install
|
@ReubenFrankel Does that exit with a code 1? |
Yep - working example: https://github.com/Matatika/tap-msaccess/actions/runs/7851492866/job/21428648454 I added |
Ah, that'd be a fix then! PS: it's nice to finally be able to singer-sdk in the pytest output 😁:
|
Singer SDK Version
0.35.0
Is this a regression?
Python Version
NA
Bug scope
Other
Operating System
GitHub Actions
Description
When an unsupported Python version is specified in the test workflow matrix, Poetry tries to find a different compatible Python version to install, and will use that instead if it one is available. This produces false-positives for test runs - for example, I expect the Python 3.7 test to fail here: https://github.com/ReubenFrankel/tap-f1/actions/runs/7801705432/job/21277456475#step:5:13
Code
The text was updated successfully, but these errors were encountered: