Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Default log format is lacking details #1232

Closed
edgarrmondragon opened this issue Dec 1, 2022 · 0 comments · Fixed by #1233
Closed

[Bug]: Default log format is lacking details #1232

edgarrmondragon opened this issue Dec 1, 2022 · 0 comments · Fixed by #1233
Assignees
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Dec 1, 2022

Singer SDK Version

0.14.0

Python Version

NA

Bug scope

CLI (options, error messages, logging, etc.)

Operating System

NA

Description

The default logging config has a very simple log format "{asctime} {message}":

version: 1
disable_existing_loggers: false
formatters:
console:
format: "{asctime} {message}"
style: "{"
handlers:
default:
class: logging.StreamHandler
formatter: console
stream: ext://sys.stderr
root:
level: INFO
propagate: true
handlers: [default]

I chose this format in the first iteration because it's the same as the singer-python default in https://github.com/singer-io/singer-python/blob/2c053f4c5f468235bba85a203a252438b1b3c704/singer/logging.conf#L23

It could be improved, though. And it's missing at least the logger name and log level.

Code

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant