Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shutdown from protocol? #18

Open
dmeliza opened this issue Jan 3, 2024 · 0 comments
Open

Remove shutdown from protocol? #18

dmeliza opened this issue Jan 3, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dmeliza
Copy link
Member

dmeliza commented Jan 3, 2024

I'm not sure why we put this in there. I don't know what the use case is for clients to be able to shut down a controller. Currently the only way to start the controller is by connecting to the host via ssh, so this functionality could be removed. This would probably allow us to really simplify the logic for graceful shutdowns, e.g. using CancellationTokens from tokio_util.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant