Skip to content

Commit

Permalink
feat: rename progressData.externalsMap to progressData.externals
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
progressData.externalsMap was renamed to progressData.externals
  • Loading branch information
medikoo committed Nov 14, 2018
1 parent a795dfd commit 45db94a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/private/create-progress-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

const ee = require("event-emitter");

module.exports = () => ee({ done: new Set(), ongoing: new Map(), externalsMap: new Map() });
module.exports = () => ee({ done: new Set(), ongoing: new Map(), externals: new Map() });
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,16 @@ const getLatestSupportedVersion = async ({ dependentContext, name, versionRange

module.exports = async (dependencyContext, progressData) => {
const { name } = dependencyContext;
const { externalsMap } = progressData;
if (!externalsMap.has(name)) {
const { externals } = progressData;
if (!externals.has(name)) {
const metadata = await getMetadata(name);
externalsMap.set(name, {
externals.set(name, {
currentLinkVersion: await getCurrentLinkVersion(dependencyContext),
latestVersion: metadata["dist-tags"].latest,
metadata
});
log.debug("resolved %s (external dependency) meta %o", name, externalsMap.get(name));
log.debug("resolved %s (external dependency) meta %o", name, externals.get(name));
}
dependencyContext.externalContext = externalsMap.get(name);
dependencyContext.externalContext = externals.get(name);
dependencyContext.latestSupportedVersion = await getLatestSupportedVersion(dependencyContext);
};

0 comments on commit 45db94a

Please sign in to comment.