From 3e905c1dddfc780bafab028a283e3e0c97cfc95a Mon Sep 17 00:00:00 2001 From: Mariusz Nowak Date: Wed, 10 Jul 2019 16:49:45 +0200 Subject: [PATCH] refactor: reorder logic --- .../install-external/prepare/index.js | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/private/setup-dependency/install-external/prepare/index.js b/lib/private/setup-dependency/install-external/prepare/index.js index 9f8902a..f987e82 100644 --- a/lib/private/setup-dependency/install-external/prepare/index.js +++ b/lib/private/setup-dependency/install-external/prepare/index.js @@ -38,14 +38,13 @@ module.exports = memoizee( recursive: true, force: true }); - if (versionCachePath) { - await rename(packageTmpDir, versionCachePath, { intermediate: true }); - const packageJson = getPackageJson(versionCachePath) || {}; - packageJson._npmCrossLinkCacheName = versionCacheName; - await updatePackageJson(versionCachePath, packageJson); - return versionCachePath; - } - return packageTmpDir; + if (!versionCachePath) return packageTmpDir; + + await rename(packageTmpDir, versionCachePath, { intermediate: true }); + const packageJson = getPackageJson(versionCachePath) || {}; + packageJson._npmCrossLinkCacheName = versionCacheName; + await updatePackageJson(versionCachePath, packageJson); + return versionCachePath; }, { promise: true, length: 2 } );