Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CERTIFICATES #26

Open
shikhar opened this issue Jul 28, 2021 · 2 comments
Open

Remove CERTIFICATES #26

shikhar opened this issue Jul 28, 2021 · 2 comments

Comments

@shikhar
Copy link
Contributor

shikhar commented Jul 28, 2021

As of hyperium/tonic#660, it is convenient to simply enable the tonic tls-webpki-roots crate feature.

With that feature enabled, one can omit tls_config() on the Channel and everything JustWorks:tm:

@mechiru
Copy link
Owner

mechiru commented Aug 5, 2021

@shikhar Thank you for your suggestions.
It cannot be deleted right now. That's because the user must explicitly enable the tls-webpki-roots feature.
(Some people don't want to rely on webpki-roots crate.)
So I would like to consider how to use feature gate for this crate as well. This method allows the user to decide which to use.
How about that?

@shikhar
Copy link
Contributor Author

shikhar commented Aug 6, 2021

Not a big deal, users can just choose to not use the export. But I wonder in what situation a user would be ok with the certs exported by this crate but not webpki-roots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants