From 3963892615e378b87eaedbde6aae82ccdff2c6a3 Mon Sep 17 00:00:00 2001 From: Liran Tal Date: Sun, 12 Jan 2014 23:30:30 +0200 Subject: [PATCH] small bug fix where Mongoose validation functions must always return booleans --- app/models/user.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/models/user.js b/app/models/user.js index 4b26b491ad..d3bfcbc6e3 100755 --- a/app/models/user.js +++ b/app/models/user.js @@ -48,25 +48,25 @@ var validatePresenceOf = function(value) { UserSchema.path('name').validate(function(name) { // if you are authenticating by any of the oauth strategies, don't validate if (!this.provider) return true; - return name.length; + return (typeof name === 'string' && name.length > 0); }, 'Name cannot be blank'); UserSchema.path('email').validate(function(email) { // if you are authenticating by any of the oauth strategies, don't validate if (!this.provider) return true; - return email.length; + return (typeof email === 'string' && email.length > 0); }, 'Email cannot be blank'); UserSchema.path('username').validate(function(username) { // if you are authenticating by any of the oauth strategies, don't validate if (!this.provider) return true; - return username.length; + return (typeof username === 'string' && username.length > 0); }, 'Username cannot be blank'); UserSchema.path('hashed_password').validate(function(hashed_password) { // if you are authenticating by any of the oauth strategies, don't validate if (!this.provider) return true; - return hashed_password.length; + return (typeof hashed_password === 'string' && hashed_password.length > 0); }, 'Password cannot be blank');