From 32a7408b4f3409df8c899e89e3794bd0f240fa30 Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Wed, 8 Nov 2023 16:48:14 +0100 Subject: [PATCH 1/7] fix(placement): underline "Don't want to see ads?" link on hover --- client/src/ui/organisms/placement/index.scss | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/client/src/ui/organisms/placement/index.scss b/client/src/ui/organisms/placement/index.scss index 33b9e9518312..174e0a2db19c 100644 --- a/client/src/ui/organisms/placement/index.scss +++ b/client/src/ui/organisms/placement/index.scss @@ -7,7 +7,16 @@ section.place { a:not(.button), a { color: var(--text-primary); - text-decoration: none; + + &:link, + &:visited { + text-decoration: none; + } + + &:focus, + &:hover { + text-decoration: underline; + } } .pong-box { From e8b0bbc10a6dc3fa5efce7e000117f7d831b2401 Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Wed, 8 Nov 2023 17:02:29 +0100 Subject: [PATCH 2/7] fix(placement): add hover state for "Mozilla ads" link --- client/src/ui/organisms/placement/index.scss | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/client/src/ui/organisms/placement/index.scss b/client/src/ui/organisms/placement/index.scss index 174e0a2db19c..cfe662b96142 100644 --- a/client/src/ui/organisms/placement/index.scss +++ b/client/src/ui/organisms/placement/index.scss @@ -54,6 +54,18 @@ section.place { text-decoration: underline; width: max-content; } + + a.pong-note { + &:link, + &:visited { + text-decoration: underline; + } + + &:focus, + &:hover { + text-decoration: none; + } + } } .no-pong { From d92a21a150dd08805eca07c249b12f685efd4f69 Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Thu, 30 Nov 2023 13:54:02 +0100 Subject: [PATCH 3/7] fix(placement): consolidate .pong-note style --- client/src/ui/organisms/placement/index.scss | 23 +++++++------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/client/src/ui/organisms/placement/index.scss b/client/src/ui/organisms/placement/index.scss index cfe662b96142..ab74cf09138a 100644 --- a/client/src/ui/organisms/placement/index.scss +++ b/client/src/ui/organisms/placement/index.scss @@ -54,18 +54,6 @@ section.place { text-decoration: underline; width: max-content; } - - a.pong-note { - &:link, - &:visited { - text-decoration: underline; - } - - &:focus, - &:hover { - text-decoration: none; - } - } } .no-pong { @@ -148,11 +136,16 @@ section.place { padding: 0 0.5rem 0.125rem; text-decoration: none; - &:hover, - &:focus, - &:active { + &:active, + &:link, + &:visited { text-decoration: underline; } + + &:focus, + &:hover { + text-decoration: none; + } } } From d98d42eed8ad21915c4742f04e5ffb8e43ef591c Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Thu, 30 Nov 2023 13:55:55 +0100 Subject: [PATCH 4/7] chore(placement): define active link behavior --- client/src/ui/organisms/placement/index.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/client/src/ui/organisms/placement/index.scss b/client/src/ui/organisms/placement/index.scss index ab74cf09138a..a79c865b2889 100644 --- a/client/src/ui/organisms/placement/index.scss +++ b/client/src/ui/organisms/placement/index.scss @@ -13,6 +13,7 @@ section.place { text-decoration: none; } + &:active, &:focus, &:hover { text-decoration: underline; From 7df8f54055631041ff3c705319abc94a26b6dc87 Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Thu, 30 Nov 2023 14:08:26 +0100 Subject: [PATCH 5/7] fix(placement): restrict hover behavior to .no-pong --- client/src/ui/organisms/placement/index.scss | 23 ++++++++++---------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/client/src/ui/organisms/placement/index.scss b/client/src/ui/organisms/placement/index.scss index a79c865b2889..1a3831eda90c 100644 --- a/client/src/ui/organisms/placement/index.scss +++ b/client/src/ui/organisms/placement/index.scss @@ -7,17 +7,7 @@ section.place { a:not(.button), a { color: var(--text-primary); - - &:link, - &:visited { - text-decoration: none; - } - - &:active, - &:focus, - &:hover { - text-decoration: underline; - } + text-decoration: none; } .pong-box { @@ -65,6 +55,17 @@ section.place { padding: 0; text-decoration: underline; width: 100%; + + &:link, + &:visited { + text-decoration: none; + } + + &:active, + &:focus, + &:hover { + text-decoration: underline; + } } &.side { From dba7e7bc12caf097805e93953a93e97c6dd67990 Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Thu, 30 Nov 2023 14:08:51 +0100 Subject: [PATCH 6/7] chore(placement): generalize .pong-note style --- client/src/ui/organisms/placement/index.scss | 27 +++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/client/src/ui/organisms/placement/index.scss b/client/src/ui/organisms/placement/index.scss index 1a3831eda90c..74d75c06c3d1 100644 --- a/client/src/ui/organisms/placement/index.scss +++ b/client/src/ui/organisms/placement/index.scss @@ -47,6 +47,21 @@ section.place { } } + .pong-note { + text-decoration: none; + + &:active, + &:link, + &:visited { + text-decoration: underline; + } + + &:focus, + &:hover { + text-decoration: none; + } + } + .no-pong { color: var(--text-secondary); font-size: 0.6rem; @@ -136,18 +151,6 @@ section.place { grid-area: note; margin: 0 0 auto auto; padding: 0 0.5rem 0.125rem; - text-decoration: none; - - &:active, - &:link, - &:visited { - text-decoration: underline; - } - - &:focus, - &:hover { - text-decoration: none; - } } } From 4bbcc5a8b22b32ae6c45c4c7b4c66d7f2ab5debe Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Thu, 30 Nov 2023 21:17:50 +0100 Subject: [PATCH 7/7] fix(placement): underline "Mozilla ads" only in side/bottom banner --- client/src/ui/organisms/placement/index.scss | 26 +++++++------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/client/src/ui/organisms/placement/index.scss b/client/src/ui/organisms/placement/index.scss index 74d75c06c3d1..a164b8a2b897 100644 --- a/client/src/ui/organisms/placement/index.scss +++ b/client/src/ui/organisms/placement/index.scss @@ -47,14 +47,19 @@ section.place { } } - .pong-note { + &.top .pong-note, + .no-pong { text-decoration: none; - &:active, - &:link, - &:visited { + &:focus, + &:hover { text-decoration: underline; } + } + + &.side .pong-note, + &.bottom-banner .pong-note { + text-decoration: underline; &:focus, &:hover { @@ -68,19 +73,7 @@ section.place { margin-bottom: 0.5rem; max-width: 12rem; padding: 0; - text-decoration: underline; width: 100%; - - &:link, - &:visited { - text-decoration: none; - } - - &:active, - &:focus, - &:hover { - text-decoration: underline; - } } &.side { @@ -281,7 +274,6 @@ div.empty-place { font-size: 0.625rem; grid-area: note; margin-top: 0.5rem; - text-decoration: underline; } .no-pong {