You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I was preparing the original PR, I noticed that the pages I was removing was mentioned in _redirects.txt, but I didn't modify it (point 1). When I ran yarn content delete, it didn't modify the redirects file, so I thought this was intentional (points 1 + 2). Finally, I never knew I had caused a failing error, because validation never ran for my PR (point 3).
My impressions on this:
yarn content delete should do the right thing and update _redirects.txt.
If yarn content delete can't or won't do the right thing, then the content README needs to cover this caveat.
Either way, if it's possible to break redirect validation by modifying files other than _redirects.txt, then it should run for every PR.
do you know why this is failing CI? It says (#2866 (checks)):
It’s due to the mglyph and mlabeledtr articles being removed in 44112ad/#2691 (so, heads-up to (heads-up @ddbeck) but some dangling redirects got left behind I don’t know if running yarn content delete causes those to get removed or not (so, heads-up to @mdn/core-yari-content too).
mdn/content#2871 fixes that problem. So once that PR merged, this PR can be rebased against main, and the CI failure should go away.
The text was updated successfully, but these errors were encountered:
I accidentally broke CI by removing pages in mdn/content#2691, but it was only discovered in mdn/content#2866.
Three things came together to cause this failure:
yarn content delete
doesn't make the corresponding modifications to_redirects.txt
.yarn content validate-redirects
only runs when_redirects.txt
is modified.When I was preparing the original PR, I noticed that the pages I was removing was mentioned in
_redirects.txt
, but I didn't modify it (point 1). When I ranyarn content delete
, it didn't modify the redirects file, so I thought this was intentional (points 1 + 2). Finally, I never knew I had caused a failing error, because validation never ran for my PR (point 3).My impressions on this:
yarn content delete
should do the right thing and update_redirects.txt
.yarn content delete
can't or won't do the right thing, then the content README needs to cover this caveat._redirects.txt
, then it should run for every PR.Originally posted in mdn/content#2866 (comment):
The text was updated successfully, but these errors were encountered: