Stop transcluding live sample sources

[wbamberg]

The {{EmbedLiveSample}} macro has a feature in which you can ask to include sources not from the current page but from a different page.

According to @escattone this along with {{page}} was one of the things that made KS much more complicated than it needed to be (because it introduced a build dependency between source and target).

Now we are close to 0 occurrences of {{page}} in mdn/content (thanks mostly to @hamishwillee ) it would be nice to remove this other source of complexity.

These are all the pages that make use of this feature of {{EmbedLiveSample}}:

• https://developer.mozilla.org/en-us/games/techniques/2d_collision_detection
• https://developer.mozilla.org/en-us/games/techniques/3d_on_the_web/glsl_shaders
• https://developer.mozilla.org/en-us/web/api/datatransferitemlist/remove
• https://developer.mozilla.org/en-us/web/api/dommatrixreadonly/flipx
• https://developer.mozilla.org/en-us/web/api/svgrectelement
• https://developer.mozilla.org/en-us/web/api/document/dragenter_event
• https://developer.mozilla.org/en-us/web/api/document/dragleave_event
• https://developer.mozilla.org/en-us/web/api/document/dragstart_event
• https://developer.mozilla.org/en-us/web/api/document/dragover_event
• https://developer.mozilla.org/en-us/web/api/document/drop_event
• https://developer.mozilla.org/en-us/web/api/document/dragend_event
• https://developer.mozilla.org/en-us/web/api/batterymanager/level
• https://developer.mozilla.org/en-us/web/api/svgcircleelement
• https://developer.mozilla.org/en-us/web/html/global_attributes/itemprop
• https://developer.mozilla.org/en-us/web/html/global_attributes/itemid
• https://developer.mozilla.org/en-us/web/html/global_attributes/itemref
• https://developer.mozilla.org/en-us/web/html/global_attributes/itemtype
• https://developer.mozilla.org/en-us/web/html/global_attributes/itemscope
• https://developer.mozilla.org/en-us/web/html/microdata
• https://developer.mozilla.org/en-us/web/html/element/map
• https://developer.mozilla.org/en-us/web/html/element/video
• https://developer.mozilla.org/en-us/web/css/_colon_-moz-list-bullet
• https://developer.mozilla.org/en-us/web/css/@counter-style/pad
• https://developer.mozilla.org/en-us/web/css/@counter-style/negative
• https://developer.mozilla.org/en-us/web/css/font-variant-ligatures
• https://developer.mozilla.org/en-us/web/css/flex-wrap
• https://developer.mozilla.org/en-us/web/css/font-variant
• https://developer.mozilla.org/en-us/web/css/css_positioning/understanding_z_index/stacking_context_example_1
• https://developer.mozilla.org/en-us/web/css/font-variant-alternates
• https://developer.mozilla.org/en-us/web/css/box-orient
• https://developer.mozilla.org/en-us/web/css/flex-grow
• https://developer.mozilla.org/en-us/web/css/font-language-override
• https://developer.mozilla.org/en-us/web/svg/tutorial/basic_transformations
• https://developer.mozilla.org/en-us/learn/forms/your_first_form
• https://developer.mozilla.org/en-us/mdn/kitchensink
• https://developer.mozilla.org/en-us/mdn/contribute/howto/create_an_interactive_exercise_to_help_learning_the_web

[teoli2003]

Command used to generate that list: rg "EmbedLiveSample *\(.*,.*,.*, *'.?'.*\)" -l | wc -l

[wbamberg]

Command used to generate that list: rg "EmbedLiveSample *\(.*,.*,.*, *'.?'.*\)" -l | wc -l

This is too loose, as it is catching lines like https://github.com/mdn/content/blob/main/files/en-us/web/css/filter/index.md?plain=1#L177:

{{EmbedLiveSample('blur','100%','236px','','', 'no-codepen')}}

[teoli2003]

I think this is better: rg "EmbedLiveSample *\([^,]*,[^,]*,[^,]*,[^,]*, *'[^'][^']*'" -i

(I've updated the link in the OP)

[hamishwillee]

Excellent idea. Once we're done, I think we should explicitly prohibit this macro importing from other pages.

[teoli2003]

So, most of them were fake transclusions 😄

[teoli2003]

Excellent idea. Once we're done, I think we should explicitly prohibit this macro importing from other pages.

Given that this macro param is (still) used on mdn/translated-content, we can't just remove the mechanism associated with the parameter.

But maybe we can add a non-failing (à la mdn.deprecated()) flaw that would warn us if such a thing is used on mdn/content.

[OnkarRuikar]

But maybe we can add a non-failing (à la mdn.deprecated()) flaw that would warn us if such a thing is used on mdn/content.

I think if we remove the usage from the documentation then we won't see new cases.
Also, contributors will prefer to write a new code instead of looking for existing code that achieves intended output. 🤔

[teoli2003]

They can forget a parameter and suddenly there is something in the parameter that will break the system. I've seen numerous typos appearing in the flaw dashboard (and mixing the number of empty parameters is easy), despite the review system. I would prefer to have a security net here given I don't see transclusion going away soon in mdn/translated-content.

[OnkarRuikar]

Need to update the list in OP. It shows 6 tasks remaining.

[OnkarRuikar]

Looks like transclusion hasn't reached the conclusion 🙃:

• Learn/Forms/How_to_build_custom_form_controls
• Web/API/Canvas_API/Tutorial/Compositing

The regexes didn't use double quotes.

[teoli2003]

Let's reopen this.

[wbamberg]

GitHub needs a :sob reaction.

[Josh-Cena]

For reference, here's a working regex you could use: EmbedLiveSample *\((?:[^,]*?,){4} *(['"])[^'"]+\1

[Josh-Cena]

#28376 and #27813

[wbamberg]

🎉 great work @queengooborg and @cw118 !

[hamishwillee]

What he said ^^^^ !!!!