Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter for obsolete data: lint for "feature[s] unsupported in all releases in the past five years" #16547

Closed
bershanskiy opened this issue Jun 5, 2022 · 1 comment
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@bershanskiy
Copy link
Contributor

This is a low-priority issue, I'm just recording it here for posterity.

In #16429 we added a linter rule for data guideline called "Removal of irrelevant features". However, this linter currently checks only for the first two rules:

  • a feature was never implemented in any browser and the specification has been abandoned.
  • a feature was implemented and has since been removed from all browsers dating back two or more years ago.

The third rule is currently not validated:

  • a feature is unsupported in all releases in the past five years.

@queengooborg suggested we should implement it:

For a follow-up, I think we could also enforce the third condition for irrelevant features, where it can be removed if "a feature is unsupported in all releases in the past five years" so we can track IE-only features better. Something for the future though!

I'm not entirely sure I understand the guideline. From reading #6429, I see that it is just a special clause written specifically for Internet Explorer. But this source seems to suggest that the last release of IE 11 happened as late as 2019 (which is only 3 years ago, less than 5). I'm not sure whether that counts as a release.

@queengooborg queengooborg added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Jun 5, 2022
@queengooborg
Copy link
Contributor

Since we're planning on removing IE from BCD altogether, I now think that we no longer have to add a linter for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

No branches or pull requests

2 participants