Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS gap, column-gap, row-gap - missing top-level _compat #11559

Closed
meyerweb opened this issue Jul 16, 2021 · 3 comments
Closed

CSS gap, column-gap, row-gap - missing top-level _compat #11559

meyerweb opened this issue Jul 16, 2021 · 3 comments
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS

Comments

@meyerweb
Copy link
Contributor

The following files are missing a top-level _compat object:

This appears to be breaking the “Specifications” macros on the following MDN pages:

I considered just adding top-level _compat with a spec_url and leaving it at that, but can’t test MDN macro resolution on my local install at present, so can’t test whether that breaks other things, so decided to file an issue here instead.

If someone can point me at what exactly I need to add to make this work without breaking other stuff, I can make the edits and submit a PR myself.

@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jul 17, 2021
@meyerweb
Copy link
Contributor Author

Following up: I got a local copy of everything up and running, including working off my local branch of BCD. After a fair bit of experimentation, I discovered that adding a top-level __compat to the beginning of gap.json as follows…

{
  "css": {
    "properties": {
      "gap": {
        "__compat": {
          "spec_url": "https://drafts.csswg.org/css-align/#gap-shorthand",
          "support": {
          }
        },

…was the minimum I could add in and get the specification link to appear while not breaking either the BCD table, or the page as a whole. This did cause the BCD table to add a row labeled gap with all question marks, but the rest of the BCD table was correct. If I remove the support object, the page fails to render, as it would seem the document building process requires its presence in a __compat object.

Is there another way to add specification URLs to BCD objects, one that sidesteps the support requirement? If not, I can add support information to the top-level object at the cost of prepending a row to the BCD table, but that strikes me as inelegant and fragile over long time scales.

@Elchi3
Copy link
Member

Elchi3 commented Aug 4, 2021

This is related to #6175

@queengooborg
Copy link
Contributor

This has been fixed by #17130!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

No branches or pull requests

3 participants