From b55937c1f22bd878c28108c7dd143ba2b8d3db38 Mon Sep 17 00:00:00 2001 From: Mihai Todor Date: Tue, 14 Nov 2023 23:23:00 +0000 Subject: [PATCH 1/3] Add database driver note to SQL Wait strategy docs (#1916) Signed-off-by: Mihai Todor --- docs/features/wait/sql.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/features/wait/sql.md b/docs/features/wait/sql.md index 5e261cf6c6..19efdab659 100644 --- a/docs/features/wait/sql.md +++ b/docs/features/wait/sql.md @@ -20,3 +20,5 @@ req := ContainerRequest{ WithQuery("SELECT 10"), } ``` + +Note: You'll also need to import the appropriate [database driver](https://github.com/golang/go/wiki/SQLDrivers) in your test code such that Testcontainers can pick it up when connecting to the database. From 181897116febbf95410560096466daa0045df85e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Wed, 15 Nov 2023 13:26:32 +0100 Subject: [PATCH 2/3] docs: fix code snippet for image substitution (#1918) --- docs/features/image_name_substitution.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features/image_name_substitution.md b/docs/features/image_name_substitution.md index ebf9bb1cda..fe8729e9c7 100644 --- a/docs/features/image_name_substitution.md +++ b/docs/features/image_name_substitution.md @@ -5,6 +5,6 @@ An image name substitutor converts a Docker image name, as may be specified in c _Testcontainers for Go_ exposes an interface to perform this operations: `ImageSubstitutor`, and a No-operation implementation to be used as reference for custom implementations: -[Image Substitutor Interface](../../generic.go) inside_block:imageSubstitutor +[Image Substitutor Interface](../../options.go) inside_block:imageSubstitutor [Noop Image Substitutor](../../container_test.go) inside_block:noopImageSubstitutor From 68d5f8983d091f4e7867c3864242d4a9727ec1c7 Mon Sep 17 00:00:00 2001 From: Joshua Powers Date: Thu, 16 Nov 2023 07:04:48 -0700 Subject: [PATCH 3/3] fix(modules.kafka): Switch to MaxInt for 32-bit support (#1923) fixes: #1921 --- modules/kafka/kafka.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/kafka/kafka.go b/modules/kafka/kafka.go index 016509229b..399f17fb70 100644 --- a/modules/kafka/kafka.go +++ b/modules/kafka/kafka.go @@ -52,7 +52,7 @@ func RunContainer(ctx context.Context, opts ...testcontainers.ContainerCustomize "KAFKA_OFFSETS_TOPIC_NUM_PARTITIONS": "1", "KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR": "1", "KAFKA_TRANSACTION_STATE_LOG_MIN_ISR": "1", - "KAFKA_LOG_FLUSH_INTERVAL_MESSAGES": fmt.Sprintf("%d", math.MaxInt64), + "KAFKA_LOG_FLUSH_INTERVAL_MESSAGES": fmt.Sprintf("%d", math.MaxInt), "KAFKA_GROUP_INITIAL_REBALANCE_DELAY_MS": "0", "KAFKA_NODE_ID": "1", "KAFKA_PROCESS_ROLES": "broker,controller",