-
Notifications
You must be signed in to change notification settings - Fork 6
/
Copy pathtest_profile_views.py
1535 lines (1236 loc) · 55.3 KB
/
test_profile_views.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
from dataclasses import asdict
from datetime import date
from unittest.mock import patch
from django import forms
from django.conf import settings
from django.template.defaultfilters import date as django_date
from django.test import TestCase, override_settings, tag
from django.urls import reverse, reverse_lazy
from django.utils.translation import gettext as _
import requests_mock
from django_webtest import WebTest
from freezegun import freeze_time
from pyquery import PyQuery
from webtest import Upload
from open_inwoner.accounts.choices import NotificationChannelChoice, StatusChoices
from open_inwoner.cms.profile.cms_appconfig import ProfileConfig
from open_inwoner.configurations.models import SiteConfiguration
from open_inwoner.haalcentraal.tests.mixins import HaalCentraalMixin
from open_inwoner.laposta.models import LapostaConfig
from open_inwoner.laposta.tests.factories import LapostaListFactory, MemberFactory
from open_inwoner.openklant.models import ESuiteKlantConfig
from open_inwoner.pdc.tests.factories import CategoryFactory
from open_inwoner.plans.tests.factories import PlanFactory
from open_inwoner.qmatic.tests.data import QmaticMockData
from open_inwoner.utils.forms import ErrorMessageMixin
from open_inwoner.utils.logentry import LOG_ACTIONS
from open_inwoner.utils.test import ClearCachesMixin
from open_inwoner.utils.tests.helpers import AssertTimelineLogMixin, create_image_bytes
from ...cms.cases.cms_apps import CasesApphook
from ...cms.collaborate.cms_apps import CollaborateApphook
from ...cms.inbox.cms_apps import InboxApphook
from ...cms.profile.cms_apps import ProfileApphook
from ...cms.tests import cms_tools
from ...haalcentraal.api_models import BRPData
from ...openklant.tests.data import MockAPIReadPatchData
from ...questionnaire.tests.factories import QuestionnaireStepFactory
from ..choices import ContactTypeChoices, LoginTypeChoices
from ..forms import BrpUserForm, UserForm
from ..models import User
from .factories import (
ActionFactory,
DigidUserFactory,
UserFactory,
eHerkenningUserFactory,
)
# Avoid redirects through `KvKLoginMiddleware`
PATCHED_MIDDLEWARE = [
m
for m in settings.MIDDLEWARE
if m != "open_inwoner.kvk.middleware.KvKLoginMiddleware"
]
@override_settings(
ROOT_URLCONF="open_inwoner.cms.tests.urls", MIDDLEWARE=PATCHED_MIDDLEWARE
)
class ProfileViewTests(WebTest):
def setUp(self):
self.url = reverse("profile:detail")
self.return_url = reverse("logout")
self.user = UserFactory(
first_name="Erik", street="MyStreet", messages_notifications=True
)
self.digid_user = DigidUserFactory()
self.eherkenning_user = eHerkenningUserFactory()
self.action_deleted = ActionFactory(
name="deleted action, should not show up",
created_by=self.user,
is_deleted=True,
status=StatusChoices.open,
)
cms_tools.create_homepage()
self.profile_app = ProfileConfig.objects.create(
namespace=ProfileApphook.app_name
)
cms_tools.create_apphook_page(ProfileApphook)
def test_login_required(self):
login_url = reverse("login")
response = self.app.get(self.url)
self.assertRedirects(response, f"{login_url}?next={self.url}")
def test_show_correct_logout_button_for_login_type_default(self):
response = self.app.get(self.url, user=self.user)
logout_title = _("Logout")
logout_link = response.pyquery.find(f"[title='{logout_title}']")
self.assertEqual(logout_link.attr("href"), reverse("logout"))
@patch("open_inwoner.accounts.models.OpenIDDigiDConfig.get_solo")
def test_show_correct_logout_button_for_login_type_digid(self, mock_solo):
for oidc_enabled in [True, False]:
with self.subTest(oidc_enabled=oidc_enabled):
mock_solo.return_value.enabled = oidc_enabled
logout_url = (
reverse("digid_oidc:logout")
if oidc_enabled
else reverse("digid:logout")
)
response = self.app.get(self.url, user=self.digid_user)
logout_title = _("Logout")
logout_link = response.pyquery.find(f"[title='{logout_title}']")
self.assertEqual(logout_link.attr("href"), logout_url)
@patch("open_inwoner.accounts.models.OpenIDEHerkenningConfig.get_solo")
def test_show_correct_logout_button_for_login_type_eherkenning(self, mock_solo):
for oidc_enabled in [True, False]:
with self.subTest(oidc_enabled=oidc_enabled):
mock_solo.return_value.enabled = oidc_enabled
logout_url = (
reverse("eherkenning_oidc:logout")
if oidc_enabled
else reverse("logout")
)
response = self.app.get(self.url, user=self.eherkenning_user)
logout_title = _("Logout")
logout_link = response.pyquery.find(f"[title='{logout_title}']")
self.assertEqual(logout_link.attr("href"), logout_url)
@patch(
"open_inwoner.cms.utils.page_display.inbox_page_is_published", return_value=True
)
def test_user_information_profile_page(self, m):
response = self.app.get(self.url, user=self.user)
self.assertContains(response, self.user.first_name)
self.assertContains(response, f"Welkom, {self.user.display_name}")
self.assertContains(response, f"{self.user.infix} {self.user.last_name}")
self.assertContains(response, self.user.email)
self.assertContains(response, self.user.phonenumber)
self.assertContains(response, self.user.street)
self.assertContains(response, self.user.housenumber)
self.assertContains(response, self.user.city)
# check business profile section not displayed
self.assertNotContains(response, "Bedrijfsgegevens")
# check notification preferences displayed
doc = PyQuery(response.content)
notifications_text = doc.find("#profile-notifications")[0].text_content()
self.assertIn("Mijn Berichten", notifications_text)
@patch(
"open_inwoner.cms.utils.page_display.inbox_page_is_published", return_value=True
)
def test_admin_disable_options(self, m):
config = SiteConfiguration.get_solo()
config.notifications_actions_enabled = False
config.notifications_cases_enabled = False
config.notifications_messages_enabled = False
config.notifications_plans_enabled = False
config.save()
response = self.app.get(self.url, user=self.user)
doc = PyQuery(response.content)
self.assertEqual(doc.find("#profile-notifications"), [])
def test_get_empty_profile_page(self):
response = self.app.get(self.url, user=self.user)
self.assertEqual(response.status_code, 200)
self.assertContains(response, _("U heeft geen interesses gekozen."))
self.assertContains(response, _("U heeft nog geen contacten"))
self.assertContains(response, "0 acties staan open")
self.assertNotContains(response, reverse("products:questionnaire_list"))
def test_get_filled_profile_page(self):
ActionFactory(created_by=self.user)
contact = UserFactory()
self.user.user_contacts.add(contact)
category = CategoryFactory()
self.user.selected_categories.add(category)
QuestionnaireStepFactory(published=True)
response = self.app.get(self.url, user=self.user)
self.assertEqual(response.status_code, 200)
self.assertContains(response, category.name)
self.assertContains(
response,
f"{contact.first_name} ({contact.get_contact_type_display()})",
)
self.assertContains(response, "1 acties staan open")
self.assertContains(response, reverse("products:questionnaire_list"))
def test_only_open_actions(self):
ActionFactory(created_by=self.user, status=StatusChoices.closed)
response = self.app.get(self.url, user=self.user)
self.assertIn("0 acties staan open", response)
def test_mydata_shown_with_digid_and_brp(self):
user = UserFactory(
bsn="999993847",
first_name="name",
last_name="surname",
is_prepopulated=True,
login_type=LoginTypeChoices.digid,
)
response = self.app.get(self.url, user=user)
self.assertContains(response, _("Bekijk alle gegevens"))
# check business profile section not displayed
self.assertNotContains(response, "Bedrijfsgegevens")
def test_mydata_not_shown_with_digid_and_no_brp(self):
user = UserFactory(
bsn="999993847",
first_name="name",
last_name="surname",
is_prepopulated=False,
login_type=LoginTypeChoices.digid,
)
response = self.app.get(self.url, user=user)
self.assertNotContains(response, _("My details"))
def test_mydata_not_shown_without_digid(self):
response = self.app.get(self.url, user=self.user)
self.assertNotContains(response, _("My details"))
def test_info_eherkenning_user(self):
user = eHerkenningUserFactory(
company_name="Makers and Shakers",
street="Fantasiestraat",
housenumber="42",
postcode="1234 XY",
city="The good place",
)
response = self.app.get(self.url, user=user)
self.assertContains(response, "Makers and Shakers")
self.assertContains(response, "Fantasiestraat 42")
self.assertContains(response, "1234 XY The good place")
doc = PyQuery(response.content)
business_section = doc.find("#business-overview")[0]
self.assertEqual(business_section.text.strip(), "Bedrijfsgegevens")
# check personal overview section not displayed
personal_section = doc.find("#personal-overview")
self.assertEqual(personal_section, [])
@patch("open_inwoner.cms.utils.page_display._is_published", return_value=True)
def test_active_user_notifications_are_shown(self, mock_page_display):
user = UserFactory(
bsn="999993847",
first_name="name",
last_name="surname",
is_prepopulated=False,
login_type=LoginTypeChoices.digid,
messages_notifications=True,
plans_notifications=True,
cases_notifications=False,
)
response = self.app.get(self.url, user=user)
self.assertContains(response, _("Mijn Berichten, Samenwerken"))
def test_expected_message_is_shown_when_all_notifications_disabled(self):
self.user.cases_notifications = False
self.user.messages_notifications = False
self.user.plans_notifications = False
self.user.save()
response = self.app.get(self.url, user=self.user)
self.assertContains(response, _("You do not have any notifications enabled."))
def test_messages_enabled_disabled(self):
"""Assert that `Stuur een bericht` is displayed if and only if the message page is published"""
begeleider = UserFactory(contact_type=ContactTypeChoices.begeleider)
self.user.user_contacts.add(begeleider)
# case 1: no message page
response = self.app.get(self.url, user=self.user)
self.assertNotContains(response, _("Stuur een bericht"))
# case 2: unpublished message page
page = cms_tools.create_apphook_page(InboxApphook, publish=False)
response = self.app.get(self.url, user=self.user)
self.assertNotContains(response, _("Stuur een bericht"))
# case 3: published message page
page.publish("nl")
page.save()
response = self.app.get(self.url, user=self.user)
message_link = response.pyquery("[title='Stuur een bericht']")
link_text = message_link.find(".link__text").text
self.assertEqual(link_text(), _("Stuur een bericht"))
@override_settings(
ROOT_URLCONF="open_inwoner.cms.tests.urls", MIDDLEWARE=PATCHED_MIDDLEWARE
)
class EditProfileTests(AssertTimelineLogMixin, WebTest):
def setUp(self):
self.url = reverse("profile:edit")
self.return_url = reverse("profile:detail")
self.user = UserFactory()
self.eherkenning_user = eHerkenningUserFactory()
def upload_test_image_to_profile_edit_page(self, img_bytes):
response = self.app.get(self.url, user=self.user, status=200)
form = response.forms["profile-edit"]
form["image"] = Upload("test_image.png", img_bytes, "image/png")
response = form.submit()
return response
def test_login_required(self):
login_url = reverse("login")
response = self.app.get(self.url)
self.assertRedirects(response, f"{login_url}?next={self.url}")
def test_save_form(self):
response = self.app.get(self.url, user=self.user)
self.assertEqual(response.status_code, 200)
form = response.forms["profile-edit"]
base_response = form.submit()
self.assertEqual(base_response.url, self.return_url)
followed_response = base_response.follow()
self.assertEqual(followed_response.status_code, 200)
def test_save_empty_form_fails(self):
response = self.app.get(self.url, user=self.user, status=200)
form = response.forms["profile-edit"]
form["first_name"] = ""
form["last_name"] = ""
form["email"] = ""
form["phonenumber"] = ""
form["phonenumber_alternative"] = ""
form["street"] = ""
form["housenumber"] = ""
form["postcode"] = ""
form["city"] = ""
base_response = form.submit()
expected_errors = {
"email": [
_(
'Het verplichte veld "E-mailadres" is niet (goed) ingevuld. Vul het veld in.'
)
]
}
self.assertEqual(base_response.context["form"].errors, expected_errors)
def test_save_filled_form(self):
response = self.app.get(self.url, user=self.user, status=200)
form = response.forms["profile-edit"]
form["first_name"] = "First name"
form["last_name"] = "Last name"
form["email"] = "user@example.com"
form["phonenumber"] = "0612345678"
form["phonenumber_alternative"] = "0687654321"
form["street"] = "Keizersgracht"
form["housenumber"] = "17 d"
form["postcode"] = "1013 RM"
form["city"] = "Amsterdam"
base_response = form.submit()
self.assertEqual(base_response.url, self.return_url)
followed_response = base_response.follow()
self.assertEqual(followed_response.status_code, 200)
self.user.refresh_from_db()
self.assertEqual(self.user.first_name, "First name")
self.assertEqual(self.user.last_name, "Last name")
self.assertEqual(self.user.display_name, "First name")
self.assertEqual(self.user.email, "user@example.com")
self.assertEqual(self.user.phonenumber, "0612345678")
self.assertEqual(self.user.phonenumber_alternative, "0687654321")
self.assertEqual(self.user.street, "Keizersgracht")
self.assertEqual(self.user.housenumber, "17 d")
self.assertEqual(self.user.postcode, "1013 RM")
self.assertEqual(self.user.city, "Amsterdam")
def test_name_validation(self):
invalid_characters = '<>#/"\\,.:;'
response = self.app.get(self.url, user=self.user, status=200)
form = response.forms["profile-edit"]
for char in invalid_characters:
with self.subTest(char=char):
form["first_name"] = "test" + char
form["infix"] = char + "test"
form["last_name"] = "te" + char + "st"
form["city"] = "te" + char + "st"
form["street"] = "te" + char + "st"
response = form.submit()
error_msg = _(
"Please make sure your input contains only valid characters "
"(letters, numbers, apostrophe, dash, space)."
)
expected_errors = {
"first_name": [error_msg],
"infix": [error_msg],
"last_name": [error_msg],
"city": [error_msg],
"street": [error_msg],
}
self.assertEqual(response.context["form"].errors, expected_errors)
def test_modify_email_succeeds(self):
response = self.app.get(self.url, user=self.user)
form = response.forms["profile-edit"]
form["email"] = "user@example.com"
response = form.submit()
self.user.refresh_from_db()
self.assertEqual(response.url, self.return_url)
self.assertEqual(self.user.email, "user@example.com")
def test_modify_contact_details_eherkenning_succeeds(self):
response = self.app.get(self.url, user=self.eherkenning_user)
form = response.forms["profile-edit"]
form["email"] = "user@example.com"
form["phonenumber"] = "0612345678"
form["phonenumber_alternative"] = "0687654321"
response = form.submit()
self.eherkenning_user.refresh_from_db()
self.assertEqual(response.url, self.return_url)
self.assertEqual(self.eherkenning_user.email, "user@example.com")
self.assertEqual(self.eherkenning_user.phonenumber, "0612345678")
self.assertEqual(self.eherkenning_user.phonenumber_alternative, "0687654321")
def test_updating_a_field_without_modifying_email_succeeds(self):
initial_email = self.user.email
initial_first_name = self.user.first_name
response = self.app.get(self.url, user=self.user)
form = response.forms["profile-edit"]
form["first_name"] = "Testing"
response = form.submit()
self.assertEqual(self.user.first_name, initial_first_name)
self.user.refresh_from_db()
self.assertEqual(response.url, self.return_url)
self.assertEqual(self.user.email, initial_email)
self.assertEqual(self.user.first_name, "Testing")
def test_form_for_digid_brp_user_saves_data(self):
user = UserFactory(
bsn="999993847",
first_name="name",
last_name="surname",
is_prepopulated=True,
login_type=LoginTypeChoices.digid,
)
response = self.app.get(self.url, user=user)
form = response.forms["profile-edit"]
# check that first_name field is not rendered for digid_brp_user
with self.assertRaises(AssertionError):
form["first_name"] = "test"
form["email"] = "user@example.com"
form["phonenumber"] = "0612345678"
form["phonenumber_alternative"] = "0687654321"
response = form.submit()
self.assertEqual(response.url, self.return_url)
user.refresh_from_db()
self.assertEqual(user.display_name, "name")
self.assertEqual(user.email, "user@example.com")
self.assertEqual(user.phonenumber, "0612345678")
self.assertEqual(user.phonenumber_alternative, "0687654321")
def test_expected_form_is_rendered(self):
# regular user
response = self.app.get(self.url, user=self.user)
form = response.context["form"]
self.assertEqual(type(form), UserForm)
# digid-brp user
user = UserFactory(
bsn="999993847",
first_name="name",
last_name="surname",
is_prepopulated=True,
login_type=LoginTypeChoices.digid,
)
response = self.app.get(self.url, user=user)
form = response.context["form"]
self.assertEqual(type(form), BrpUserForm)
def test_image_is_saved_when_begeleider_and_default_login(self):
self.user.contact_type = ContactTypeChoices.begeleider
self.user.save()
img_bytes = create_image_bytes()
form_response = self.upload_test_image_to_profile_edit_page(img_bytes)
self.assertRedirects(form_response, reverse("profile:detail"))
with self.assertRaisesMessage(
ValueError, "The 'image' attribute has no file associated with it."
):
self.user.image.file
self.user.refresh_from_db()
self.assertIsNotNone(self.user.image.file)
def test_image_is_saved_when_begeleider_and_digid_login(self):
self.user.contact_type = ContactTypeChoices.begeleider
self.user.login_type = LoginTypeChoices.digid
self.user.save()
img_bytes = create_image_bytes()
form_response = self.upload_test_image_to_profile_edit_page(img_bytes)
self.assertRedirects(form_response, reverse("profile:detail"))
with self.assertRaisesMessage(
ValueError, "The 'image' attribute has no file associated with it."
):
self.user.image.file
self.user.refresh_from_db()
self.assertIsNotNone(self.user.image.file)
def test_image_field_is_not_rendered_when_begeleider_and_default_login(self):
response = self.app.get(self.url, user=self.user, status=200)
form = response.forms["profile-edit"]
self.assertNotIn("image", form.fields.keys())
self.assertEqual(response.pyquery("#id_image"), [])
def test_image_field_is_not_rendered_when_begeleider_and_digid_login(self):
self.user.login_type = LoginTypeChoices.digid
self.user.save()
response = self.app.get(self.url, user=self.user, status=200)
form = response.forms["profile-edit"]
self.assertNotIn("image", form.fields.keys())
self.assertEqual(response.pyquery("#id_image"), [])
@requests_mock.Mocker()
def test_modify_phone_and_email_updates_klant_api(self, m):
MockAPIReadPatchData.setUpServices()
data = MockAPIReadPatchData().install_mocks(m)
response = self.app.get(self.url, user=data.user)
# reset noise from signals
m.reset_mock()
self.clearTimelineLogs()
form = response.forms["profile-edit"]
form["email"] = "new@example.com"
form["phonenumber"] = "0612345678"
form["phonenumber_alternative"] = "0687654321"
form.submit()
# user data tested in other cases
self.assertTrue(data.matchers[0].called)
klant_patch_data = data.matchers[1].request_history[0].json()
self.assertEqual(
klant_patch_data,
{
"emailadres": "new@example.com",
"telefoonnummer": "0612345678",
"telefoonnummerAlternatief": "0687654321",
},
)
self.assertTimelineLog("retrieved klant for user")
self.assertTimelineLog(
"patched klant from user profile edit with fields: emailadres, telefoonnummer, telefoonnummerAlternatief"
)
@requests_mock.Mocker()
def test_eherkenning_user_updates_klant_api(self, m):
MockAPIReadPatchData.setUpServices()
for use_rsin_for_innNnpId_query_parameter in [True, False]:
with self.subTest(
use_rsin_for_innNnpId_query_parameter=use_rsin_for_innNnpId_query_parameter
):
# NOTE Explicitly creating a new Mocker object here, because for some reason
# `m` is overridden somewhere, which causes issues when `MockAPIReadPatchData.install_mocks`
# is run for the second time
with requests_mock.Mocker() as m:
data = MockAPIReadPatchData().install_mocks_eherkenning(
m, use_rsin=use_rsin_for_innNnpId_query_parameter
)
config = ESuiteKlantConfig.get_solo()
config.use_rsin_for_innNnpId_query_parameter = (
use_rsin_for_innNnpId_query_parameter
)
config.save()
response = self.app.get(self.url, user=data.eherkenning_user)
# reset noise from signals
m.reset_mock()
self.clearTimelineLogs()
form = response.forms["profile-edit"]
form["email"] = "new@example.com"
form["phonenumber"] = "0612345678"
form.submit()
# user data tested in other cases
self.assertTrue(data.matchers[0].called)
klant_patch_data = data.matchers[1].request_history[0].json()
self.assertEqual(
klant_patch_data,
{
"emailadres": "new@example.com",
"telefoonnummer": "0612345678",
},
)
self.assertTimelineLog("retrieved klant for user")
self.assertTimelineLog(
"patched klant from user profile edit with fields: emailadres, telefoonnummer"
)
@requests_mock.Mocker()
def test_no_edited_fields_does_not_push_to_esuite(self, m):
MockAPIReadPatchData.setUpServices()
data = MockAPIReadPatchData().install_mocks(m)
response = self.app.get(self.url, user=data.user)
# reset noise from signals
m.reset_mock()
self.clearTimelineLogs()
form = response.forms["profile-edit"]
form.submit()
# user data tested in other cases
self.assertFalse(data.matchers[0].called)
self.assertFalse(data.matchers[1].called)
@requests_mock.Mocker()
def test_modify_phone_updates_klant_api_but_skip_unchanged_email(self, m):
MockAPIReadPatchData.setUpServices()
data = MockAPIReadPatchData().install_mocks(m)
response = self.app.get(self.url, user=data.user)
# reset noise from signals
m.reset_mock()
self.clearTimelineLogs()
form = response.forms["profile-edit"]
form["phonenumber"] = "0612345678"
form.submit()
# user data tested in other cases
self.assertTrue(data.matchers[0].called)
klant_patch_data = data.matchers[1].request_history[0].json()
self.assertEqual(
klant_patch_data,
{
"telefoonnummer": "0612345678",
},
)
self.assertTimelineLog("retrieved klant for user")
self.assertTimelineLog(
"patched klant from user profile edit with fields: telefoonnummer"
)
@requests_mock.Mocker()
def test_modify_email_updates_klant_api_but_skip_unchanged_phone(self, m):
MockAPIReadPatchData.setUpServices()
data = MockAPIReadPatchData().install_mocks(m)
response = self.app.get(self.url, user=data.user)
# reset noise from signals
m.reset_mock()
self.clearTimelineLogs()
form = response.forms["profile-edit"]
form["email"] = "new@example.com"
form.submit()
# user data tested in other cases
self.assertTrue(data.matchers[0].called)
klant_patch_data = data.matchers[1].request_history[0].json()
self.assertEqual(
klant_patch_data,
{
"emailadres": "new@example.com",
},
)
self.assertTimelineLog("retrieved klant for user")
self.assertTimelineLog(
"patched klant from user profile edit with fields: emailadres"
)
class TestForm(ErrorMessageMixin, forms.Form):
name = forms.CharField(required=True, label="Naam")
email = forms.EmailField(required=True, label="E-mailadres")
class ErrorMessageMixinTest(TestCase):
def test_default_error_messages(self):
form = TestForm(data={})
self.assertEqual(
form.errors["name"],
[_('Het verplichte veld "Naam" is niet (goed) ingevuld. Vul het veld in.')],
)
self.assertEqual(
form.errors["email"],
[
_(
'Het verplichte veld "E-mailadres" is niet (goed) ingevuld. Vul het veld in.'
)
],
)
def test_custom_error_messages(self):
custom_messages = {
"name": {"required": _("Naam is verplicht.")},
"email": {"required": _("E-mail is verplicht.")},
}
form = TestForm(data={}, custom_error_messages=custom_messages)
self.assertEqual(form.errors["name"], [_("Naam is verplicht.")])
self.assertEqual(form.errors["email"], [_("E-mail is verplicht.")])
@override_settings(ROOT_URLCONF="open_inwoner.cms.tests.urls")
class ProfileDeleteTest(WebTest):
csrf_checks = False
@classmethod
def setUpTestData(cls):
cls.url = reverse("profile:detail")
def test_delete_regular_user_success(self):
user = UserFactory()
# get profile page
response = self.app.get(self.url, user=user)
# check delete
response = response.forms["delete-form"].submit()
self.assertIsNone(User.objects.first())
# check redirect
self.assertRedirects(
self.app.get(response.url),
reverse("login"),
status_code=302,
target_status_code=200,
fetch_redirect_response=True,
)
def test_delete_user_with_digid_login_success(self):
user = DigidUserFactory()
# get profile page
response = self.app.get(self.url, user=user)
# check user deleted
response = response.forms["delete-form"].submit()
self.assertIsNone(User.objects.first())
# check redirect
self.assertRedirects(
self.app.get(response.url),
reverse("login"),
status_code=302,
target_status_code=200,
fetch_redirect_response=True,
)
def test_delete_regular_user_as_plan_contact_fail(self):
user = UserFactory()
PlanFactory.create(plan_contacts=[user])
# get profile page
response = self.app.get(self.url, user=user)
# check user not deleted
response = response.forms["delete-form"].submit()
self.assertEqual(User.objects.first(), user)
# check redirect
self.assertRedirects(
response,
reverse("profile:detail"),
status_code=302,
target_status_code=200,
fetch_redirect_response=True,
)
def test_delete_staff_user_via_frontend_does_not_work(self):
user = UserFactory(is_staff=True)
# get profile page
response = self.app.get(self.url, user=user)
# check staff user not deleted
response = response.forms["delete-form"].submit()
self.assertEqual(User.objects.first(), user)
# check redirect
self.assertRedirects(
response,
reverse("profile:detail"),
status_code=302,
target_status_code=200,
fetch_redirect_response=True,
)
@requests_mock.Mocker()
@override_settings(ROOT_URLCONF="open_inwoner.cms.tests.urls")
class MyDataTests(AssertTimelineLogMixin, HaalCentraalMixin, WebTest):
maxDiff = None
expected_response = BRPData(
first_name="Merel",
initials="M.",
last_name="Kooyman",
infix="de",
birthday=date(1982, 4, 10),
birth_place="Leerdam",
gender="vrouw",
street="King Olivereiland",
housenumber="64",
postal_code="2551JV",
city="'s-Gravenhage",
country="",
)
def setUp(self):
self.user = UserFactory(
bsn="999993847",
first_name="Merel",
infix="de",
last_name="Kooyman",
login_type=LoginTypeChoices.digid,
)
self.url = reverse("profile:data")
self.expected_strings = [
self.expected_response.first_name,
self.expected_response.infix,
self.expected_response.last_name,
django_date(self.expected_response.birthday, "j F Y"),
self.expected_response.birth_place,
self.expected_response.gender,
self.expected_response.street,
self.expected_response.get_housenumber(),
self.expected_response.postal_code,
self.expected_response.city,
self.user.bsn,
self.user.email,
self.user.phonenumber,
]
self.clearTimelineLogs()
def assertDataDisplays(self, response):
texts = set()
for elem in response.pyquery(".tabled__item:not(.tabled__item--bold)"):
s = elem.text.strip()
texts.add(s)
if missing := [s for s in self.expected_strings if s not in texts]:
f = ", ".join(f"'{s}'" for s in missing)
self.fail(f"missing display of values: {f}")
def test_expected_response_is_returned_brp_v_2(self, m):
self._setUpMocks_v_2(m)
self._setUpService()
response = self.app.get(self.url, user=self.user)
self.assertEqual(
asdict(response.context["my_data"]),
asdict(self.expected_response),
)
# self.assertDataDisplays(response)
self.assertTimelineLog(
_("user requests for brp data"),
content_object_repr=str(self.user),
action_flag=list(LOG_ACTIONS[4]),
)
@override_settings(BRP_VERSION="1.3")
def test_expected_response_is_returned_brp_v_1_3(self, m):
self._setUpMocks_v_1_3(m)
self._setUpService()
response = self.app.get(self.url, user=self.user)
self.assertEqual(
asdict(response.context["my_data"]),
asdict(self.expected_response),
)
self.assertDataDisplays(response)
self.assertTimelineLog(
_("user requests for brp data"),
content_object_repr=str(self.user),
action_flag=list(LOG_ACTIONS[4]),
)
@override_settings(BRP_VERSION="1.3")
def test_wrong_date_format_shows_birthday_none_brp_v_1_3(self, m):
self._setUpService()
m.get(
"https://personen/api/schema/openapi.yaml?v=3",
status_code=200,
content=self.load_binary_mock("personen_1.3.yaml"),
)
m.get(
"https://personen/api/brp/ingeschrevenpersonen/999993847?fields=geslachtsaanduiding,naam.voornamen,naam.geslachtsnaam,naam.voorletters,naam.voorvoegsel,verblijfplaats.straat,verblijfplaats.huisletter,verblijfplaats.huisnummertoevoeging,verblijfplaats.woonplaats,verblijfplaats.postcode,verblijfplaats.land.omschrijving,geboorte.datum.datum,geboorte.plaats.omschrijving",
status_code=200,
json={
"naam": {
"voornamen": "Merel",
"voorvoegsel": "de",
"geslachtsnaam": "Kooyman",
},
"geboorte": {
"datum": {
"datum": "1982-04",
},
},
},
)
response = self.app.get(self.url, user=self.user)
self.assertIsNone(response.context["my_data"].birthday)
self.assertTimelineLog(
_("user requests for brp data"),
content_object_repr=str(self.user),
action_flag=list(LOG_ACTIONS[4]),
)
@override_settings(ROOT_URLCONF="open_inwoner.cms.tests.urls")
class EditIntrestsTests(WebTest):
def setUp(self):
self.url = reverse("profile:categories")
self.user = UserFactory()
def test_login_required(self):
login_url = reverse("login")
response = self.app.get(self.url)
self.assertRedirects(response, f"{login_url}?next={self.url}")
def test_preselected_values(self):
category = CategoryFactory(name="a")
CategoryFactory(name="b")
CategoryFactory(name="c")
self.user.selected_categories.add(category)
response = self.app.get(self.url, user=self.user)
form = response.forms["change-categories"]
self.assertTrue(form.get("selected_categories", index=0).checked)
self.assertFalse(form.get("selected_categories", index=1).checked)
self.assertFalse(form.get("selected_categories", index=2).checked)
@override_settings(ROOT_URLCONF="open_inwoner.cms.tests.urls")
@patch("open_inwoner.cms.utils.page_display._is_published", return_value=True)
class EditNotificationsTests(AssertTimelineLogMixin, WebTest):
def setUp(self):
self.config = SiteConfiguration.get_solo()
self.config.notifications_messages_enabled = True
self.config.notifications_cases_enabled = True
self.config.notifications_plans_enabled = True
self.config.save()
self.url = reverse("profile:notifications")
self.user = UserFactory()