Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal UI > Labels #30

Closed
mfendeksilverstripe opened this issue Dec 12, 2023 · 2 comments
Closed

Modal UI > Labels #30

mfendeksilverstripe opened this issue Dec 12, 2023 · 2 comments

Comments

@mfendeksilverstripe
Copy link
Collaborator

mfendeksilverstripe commented Dec 12, 2023

Modal UI > Labels

Some of the labels are hard coded, we need to change these to pull dynamic values.

New model state

This is when user clicks on "add new" button (creating new model).

Screenshot 2023-12-13 at 9 40 38 AM

  • A - the label should be showing New {model name}
  • B - the label should be showing Create

The general aim is to make the UI labels consistent with GridField, see examples below.

Screenshot 2023-12-13 at 9 53 21 AM

Screenshot 2023-12-13 at 9 53 30 AM

Existing model state

This is when user clicks on one of the existing models (edit existing model).

Screenshot 2023-12-13 at 9 40 47 AM

  • A - the label should be showing Edit {model name}
  • B - the label should be showing Save

The general aim is to make the UI labels consistent with GridField, see example below.

Screenshot 2023-12-13 at 9 55 16 AM

@maxime-rainville
Copy link
Owner

I'm pretty confident this would be a trivial fix.

@mfendeksilverstripe
Copy link
Collaborator Author

Fixes applied in

#35
#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants