Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLF_CPP20_SUPPORT shouldn't be defined on Android NDK r24 #46

Closed
mikezackles opened this issue Apr 29, 2022 · 4 comments
Closed

PLF_CPP20_SUPPORT shouldn't be defined on Android NDK r24 #46

mikezackles opened this issue Apr 29, 2022 · 4 comments

Comments

@mikezackles
Copy link

As best I can tell, this detection is broken for the Android NDK, which ships with a copy of libc++ that does not implement the concepts header. Maybe it would be appropriate to use _LIBCPP_VERSION? There doesn't appear to be a way for users to override this behavior without patching.

@mikezackles
Copy link
Author

For what it's worth, the relevant NDK issue is android/ndk#1530. They are shipping a libc++ that's something like 2 years out of date compared to the version of clang they're shipping.

@mattreecebentley
Copy link
Owner

mattreecebentley commented May 23, 2022 via email

@mikezackles
Copy link
Author

No problem -- no rush from me. Love the lib. Thanks!

@mattreecebentley
Copy link
Owner

I think this is fixed now - please check for me-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants