-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLF_CPP20_SUPPORT shouldn't be defined on Android NDK r24 #46
Comments
For what it's worth, the relevant NDK issue is android/ndk#1530. They are shipping a libc++ that's something like 2 years out of date compared to the version of clang they're shipping. |
Hey Zachary,
thanks for getting back to me on this,
I'm currently busy on the hive (C++ standards version of colony)
implementation, but once done there (probably a month to go) will do this.
Cheers!
Matt
…On 21/05/2022 6:00 am, Zachary Michaels wrote:
For what it's worth, the relevant NDK issue is android/ndk#1530
<android/ndk#1530>. They are shipping a libc++
that's something like 2 years out of date compared to the version of
clang they're shipping.
—
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABE4FIVBAIKIWGGCS7PC54LVK7HMXANCNFSM5UXIN6IA>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
No problem -- no rush from me. Love the lib. Thanks! |
I think this is fixed now - please check for me- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As best I can tell, this detection is broken for the Android NDK, which ships with a copy of libc++ that does not implement the
concepts
header. Maybe it would be appropriate to use_LIBCPP_VERSION
? There doesn't appear to be a way for users to override this behavior without patching.The text was updated successfully, but these errors were encountered: