fix: wrap pathes for docker compose in quotes #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xVolosnikov unfortunately that doesn't work on all systems. If I remember correctly having brackets won't work correctly through windows terminal |
I never had any issues using quotes with Windows cmd. Anyway, I will search for best practices UPD: seems like brackets also can be used with quotation marks. |
JackHamer09
approved these changes
Jul 9, 2024
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JackHamer09
added a commit
that referenced
this pull request
Jul 10, 2024
This reverts commit bba983b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Fix for #133
Paths for the docker-compose command are wrapped in quotes, which avoids problems if there are spaces in the path.