Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What am I doing wrong here? #86

Closed
SaintelDaily opened this issue May 19, 2021 · 7 comments
Closed

What am I doing wrong here? #86

SaintelDaily opened this issue May 19, 2021 · 7 comments

Comments

@SaintelDaily
Copy link

SaintelDaily commented May 19, 2021

I cant seem to get this to work. What am I doing wrong?

{
module: "MMM-cryptocurrency",
position: "top_right",
config: {
apikey: 'XXXXX Hidden for Privacy XXXXX',
currency: [‘bitcoin’, 'ethereum', ‘ethereum-classic’, ‘xrp’, ‘cardano’],
conversion: ‘USD’,
headers: ['change24h', 'change1h', 'change7d'],
displayType: 'logoWithChanges',
showGraphs: true,
}
},

@branttaylor
Copy link

Same issue here. I went even simpler with my config just to try and get it working and it's just blank. I only see "Currency" and "Price" with a line underneath, nothing else.

{
                module: "MMM-cryptocurrency",
                position: "top_left",
                config: {
                        apiKey: 'redacted'
                }
}

@SaintelDaily
Copy link
Author

I just switched to JAST. It does stocks and crypto without a need for API. only downside it does not have all the crypto out there since it uses Yahoo. PRO -Tip when entering crypt, the symbol has to be in this format "BTC-USD"

https://github.com/jalibu/MMM-Jast

@matteodanelli
Copy link
Owner

Can you please tell me the MagicMirror version you are using?
I've just tested both your configurations and they work.
@branttaylor @SaintelDaily
Do you see any errors in console?
Can you see other modules?

@spacklewoof
Copy link

I am using v2.17.1 and I am getting the error mentioned in #94. The entire screen goes blank, I don't even get a warning that there is a config error. I get this:
[22.10.2021 21:32.09.826] [LOG] Module helper loaded: calendar
[22.10.2021 21:32.09.827] [ERROR] App threw an error during load
[22.10.2021 21:32.09.830] [ERROR] Error: Cannot find module 'request'
Require stack:

  • /home/pi/MagicMirror/modules/MMM-cryptocurrency/node_helper.js
  • /home/pi/MagicMirror/js/app.js
  • /home/pi/MagicMirror/js/electron.js
  • /home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
  • at Module._resolveFilename (internal/modules/cjs/loader.js:887:15)
    at Function.n._resolveFilename (electron/js2c/browser_init.js:257:1128)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/module-alias/index.js:49:29)
    at Module._load (internal/modules/cjs/loader.js:732:27)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:959:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object. (/home/pi/MagicMirror/modules/MMM-cryptocurrency/node_helper.js:2:15)
    at Module._compile (internal/modules/cjs/loader.js:1078:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1108:10)
    [22.10.2021 21:32.09.831] [ERROR] Whoops! There was an uncaught exception...
    [22.10.2021 21:32.09.837] [ERROR] Error: Cannot find module 'request'
    Require stack:
  • /home/pi/MagicMirror/modules/MMM-cryptocurrency/node_helper.js
  • /home/pi/MagicMirror/js/app.js
  • /home/pi/MagicMirror/js/electron.js
  • /home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
  • at Module._resolveFilename (internal/modules/cjs/loader.js:887:15)
    at Function.n._resolveFilename (electron/js2c/browser_init.js:257:1128)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/module-alias/index.js:49:29)
    at Module._load (internal/modules/cjs/loader.js:732:27)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:959:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object. (/home/pi/MagicMirror/modules/MMM-cryptocurrency/node_helper.js:2:15)
    at Module._compile (internal/modules/cjs/loader.js:1078:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1108:10) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [
    '/home/pi/MagicMirror/modules/MMM-cryptocurrency/node_helper.js',
    '/home/pi/MagicMirror/js/app.js',
    '/home/pi/MagicMirror/js/electron.js',
    '/home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js',
    undefined
    ]
    }
    [22.10.2021 21:32.09.840] [ERROR] MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
    [22.10.2021 21:32.09.841] [ERROR] If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues
    [22.10.2021 21:32.10.122] [LOG] Launching application.
    ^C[22.10.2021 21:32.25.610] [LOG] Shutting down server...
    [22.10.2021 21:32.25.615] [LOG] Stopping module helper: updatenotification
    [22.10.2021 21:32.25.616] [LOG] Stopping module helper: calendar
    [22.10.2021 21:32.25.617] [LOG] Stopping module helper: updatenotification
    [22.10.2021 21:32.25.619] [LOG] Stopping module helper: calendar
    [22.10.2021 21:32.25.620] [ERROR] Whoops! There was an uncaught exception...
    [22.10.2021 21:32.25.624] [ERROR] TypeError: Cannot read property 'close' of undefined
    at App.stop (/home/pi/MagicMirror/js/app.js:257:14)
    at App. (/home/pi/MagicMirror/js/electron.js:139:7)
    at App.emit (events.js:315:20)
    [22.10.2021 21:32.25.626] [ERROR] MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
    [22.10.2021 21:32.25.628] [ERROR] If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues

@spacklewoof
Copy link

go to your main magic mirror directory and type "npm install request"

After doing this, your plugin should work fine.

DanielHabenicht/MMM-json#5

@Tippon
Copy link

Tippon commented Oct 28, 2021

go to your main magic mirror directory and type "npm install request"

I was having the same issue, and this fixed it. Thank you :)

@lacalos
Copy link

lacalos commented Feb 17, 2022

hi mr matteodanelli, i can writing you for a new module amazing with crypto?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants