Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Require pusher URLs to be HTTPS and on /_matrix/push/v1/notify #3706

Closed
turt2live opened this issue Aug 16, 2018 · 5 comments
Closed

Require pusher URLs to be HTTPS and on /_matrix/push/v1/notify #3706

turt2live opened this issue Aug 16, 2018 · 5 comments
Labels
A-Push Issues related to push/notifications A-Spec-Compliance places where synapse does not conform to the spec

Comments

@turt2live
Copy link
Member

as per matrix-org/matrix-spec-proposals#1522

@neilisfragile neilisfragile added the A-Spec-Compliance places where synapse does not conform to the spec label Aug 28, 2018
@richvdh richvdh added the A-Push Issues related to push/notifications label Feb 5, 2020
@richvdh
Copy link
Member

richvdh commented Aug 11, 2020

why is this a thing? why does the pusher need to care what the push gateway's URI is?

@turt2live
Copy link
Member Author

after digging up the conversation in the spec core team room: It's for versioning.

As a requirement for r0 on the push spec, we needed a way to be able to change the format of the endpoint in the future without breaking existing servers and clients, so we mandated that the server validate the endpoint's path to ensure it had a version it could speak.

In the future we might change the request shape of the /notify endpoint, and thus increment the version. These changes might not be backwards compatible, and thus the server will need to know if it needs to speak /v2/notify or /v1/notify to the gateway.

fwiw there was some discussion about us making the hostname or other properties be a version indicator, which might still happen when/if we go to a v2 endpoint.

@richvdh
Copy link
Member

richvdh commented Aug 11, 2020

that sounds like a surprising way to solve that problem. If the server needs to support multiple notify APIs, then it should be told directly which API it needs to speak, for instance by defining a pusher kind of http_v2, rather than having to infer it from parts of the URI.

@turt2live
Copy link
Member Author

indeed that would be another way to fix it. This was all part of the r0 rush of 2018 though, so was left with a lot of room for improvement.

@richvdh
Copy link
Member

richvdh commented Aug 12, 2020

ok, I'm going to close this in favour of https://github.com/matrix-org/matrix-doc/issues/2721.

@richvdh richvdh closed this as completed Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Push Issues related to push/notifications A-Spec-Compliance places where synapse does not conform to the spec
Projects
None yet
Development

No branches or pull requests

3 participants