Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

We need to actually check the reference hashes on received events (SYN-185) #1252

Closed
matrixbot opened this issue Dec 2, 2014 · 4 comments
Closed

Comments

@matrixbot
Copy link
Member

We don't check that the hash in a reference in the prev_events, auth_events or prev_state actually matches the hash of the referenced event.

This means that the origin server of an event can change the contents if it update the hashes and signatures and synapse won't notice that the event doesn't match.

(Imported from https://matrix.org/jira/browse/SYN-185)

(Reported by @ara4n)

@matrixbot
Copy link
Member Author

Jira watchers: @NegativeMjark @ara4n

@matrixbot
Copy link
Member Author

Do you mean the reference hash rather than the content hash? Cause we check the content hash for events received over federation.

-- @NegativeMjark

@matrixbot matrixbot changed the title We need to actually check the reference hashes on received events (SYN-185) We need to actually check the reference hashes on received events (https://github.com/matrix-org/synapse/issues/1252) Nov 7, 2016
@matrixbot matrixbot changed the title We need to actually check the reference hashes on received events (https://github.com/matrix-org/synapse/issues/1252) We need to actually check the reference hashes on received events (SYN-185) Nov 7, 2016
@richvdh richvdh added security and removed z-feature (Deprecated Label) labels Apr 9, 2018
@richvdh
Copy link
Member

richvdh commented Sep 18, 2018

The solution to this is matrix-org/matrix-spec-proposals#1127.

@richvdh
Copy link
Member

richvdh commented Mar 18, 2019

this is fixed in room v3 and later by MSC1659

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants