Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Handle resending requests that we didn't successfully send if we restart. (SYN-44) #1214

Closed
matrixbot opened this issue Sep 16, 2014 · 4 comments
Closed

Handle resending requests that we didn't successfully send if we restart. (SYN-44) #1214

matrixbot opened this issue Sep 16, 2014 · 4 comments
Labels
z-feature (Deprecated Label)

Comments

@matrixbot
Copy link
Member

(Imported from https://matrix.org/jira/browse/SYN-44)

(Reported by @erikjohnston)
@matrixbot
Copy link
Member Author

Jira watchers: @erikjohnston

@matrixbot matrixbot added the z-feature (Deprecated Label) label Nov 7, 2016
@matrixbot matrixbot changed the title Handle resending requests that we didn't successfully send if we restart. (SYN-44) Handle resending requests that we didn't successfully send if we restart. (https://github.com/matrix-org/synapse/issues/1214) Nov 7, 2016
@matrixbot matrixbot changed the title Handle resending requests that we didn't successfully send if we restart. (https://github.com/matrix-org/synapse/issues/1214) Handle resending requests that we didn't successfully send if we restart. (SYN-44) Nov 7, 2016
@richvdh richvdh mentioned this issue Apr 20, 2017
Closed
@richvdh
Copy link
Member

richvdh commented Oct 11, 2017

I don't really know what this means.

@richvdh richvdh mentioned this issue Oct 11, 2017
Closed
@richvdh
Copy link
Member

richvdh commented Jul 12, 2020

I don't really know what this means.

It's pretty obvious now. Synapse makes multiple attempts to send each outbound federation transaction. If it is shut down in the middle of that process, the information on the transaction is lost, and the retry schedule for any transactions in flight are effectively truncated. Indeed, some transactions may never be sent at all.

@richvdh
Copy link
Member

richvdh commented Oct 20, 2020

I believe this is fixed by #8322.

@richvdh richvdh closed this as completed Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
z-feature (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @matrixbot