Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] does not compile with emscripten >= 1.38 #12

Closed
uhoreg opened this issue Jun 7, 2018 · 2 comments
Closed

[js] does not compile with emscripten >= 1.38 #12

uhoreg opened this issue Jun 7, 2018 · 2 comments

Comments

@uhoreg
Copy link
Member

uhoreg commented Jun 7, 2018

as 1.38 defaults to wasm, but wasm is apparently not compatible with our pre and post script somehow
(see also Kagami/ffmpeg.js#44 (comment) )

so we need to add -s WASM=0 to the EMCCFLAGS

@uhoreg
Copy link
Member Author

uhoreg commented Jun 8, 2018

even after adding -s WASM=0, there are still issues with emscripten 1.38

  • Module['Runtime'] is no longer defined. stackSave and stackRestore seem to be in Module directly now, rather than in Module['Runtime'
  • Module['allocate'] is no longer defined (it seems to be a global now?)
  • even after fixing these issues, the unit tests fail, saying abort("Assertion failed: undefined"). ☹️

@dbkr
Copy link
Member

dbkr commented Sep 26, 2018

There's now a pending PR in olm for this.

@dbkr dbkr closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants