Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nitpick] /messages "dir" parameter is ambiguous #3019

Closed
ShadowJonathan opened this issue Feb 20, 2021 · 3 comments · Fixed by #3353
Closed

[nitpick] /messages "dir" parameter is ambiguous #3019

ShadowJonathan opened this issue Feb 20, 2021 · 3 comments · Fixed by #3353

Comments

@ShadowJonathan
Copy link
Contributor

Required. The direction to return events from. One of: ["b", "f"]

This is ambiguous and not immidiately clear what each of these two values do, even if it can be deduced, it should be declared explicitly.
@ShadowJonathan ShadowJonathan changed the title /messages "dir" parameter is ambiguous [nitpick] /messages "dir" parameter is ambiguous Feb 20, 2021
@richvdh
Copy link
Member

richvdh commented Feb 22, 2021

related: #2420

@ShadowJonathan
Copy link
Contributor Author

ShadowJonathan commented Feb 22, 2021 •
edited
Loading

I'd say #2420 is the original issue on this, i'll close this and put the message on there as well.

@ShadowJonathan ShadowJonathan mentioned this issue Feb 22, 2021
Closed
@ShadowJonathan
Copy link
Contributor Author

ShadowJonathan commented Feb 22, 2021 •
edited
Loading

Oh wait no, that issue is more related to undefined behaviour with real-world examples, this is more a clarification issue, i'll re-open this, sorry for the confusion.

@richvdh richvdh mentioned this issue Aug 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarifications to pagination parameters for various APIs matrix-org/matrix-spec-proposals
2 participants
@richvdh @ShadowJonathan