Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump monolog to v2 or v3 #23009

Closed
williamdes opened this issue Feb 2, 2025 · 4 comments
Closed

Bump monolog to v2 or v3 #23009

williamdes opened this issue Feb 2, 2025 · 4 comments

Comments

@williamdes
Copy link
Contributor

Hi @sgiehl

On Debian I upgraded Monlog to v2 and then v3
See (v2): https://sources.debian.org/src/matomo/5.2.2%2Bdfsg-1/debian/patches/0006-Upgrade-monolog-to-v2.patch/
See (v3): https://sources.debian.org/src/matomo/5.2.2%2Bdfsg-1/debian/patches/0028-Upgrade-monolog-to-v3.patch/

I think I will do a PR for v2 since it is PHP 7.2 compatible: https://github.com/Seldaek/monolog/blob/2.x/composer.json#L16

@sgiehl
Copy link
Member

sgiehl commented Feb 3, 2025

Hey @williamdes,

It might be better not to patch any library updates into releases, as that can always break compatibility with various plugins.
Monolog2 seems to have a couple of breaking changes, which require changes within Matomo itself.
We most likely shouldn't do that outside of a major release, to ensure all plugins remain compatible.

@williamdes
Copy link
Contributor Author

Okay, for Debian it works differently so I do kit have the choice. But for normal distribution I totally understand.
When do you plan to open a branch for the next major version?
Should i close this issue?

@sgiehl
Copy link
Member

sgiehl commented Feb 3, 2025

We will most likely do a major somewhen this year, but it hasn't been planned yet. But updating all dependencies to newer versions will be a part of it anyway, so I'll close this issue for now.
Thanks nevertheless for your approach!

@sgiehl sgiehl closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2025
@williamdes
Copy link
Contributor Author

We will most likely do a major somewhen this year, but it hasn't been planned yet. But updating all dependencies to newer versions will be a part of it anyway, so I'll close this issue for now. Thanks nevertheless for your approach!

Okay, please ping me or check out the patches folder on Debian as the work is maybe already done and can be imported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants