-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump monolog to v2 or v3 #23009
Comments
Hey @williamdes, It might be better not to patch any library updates into releases, as that can always break compatibility with various plugins. |
Okay, for Debian it works differently so I do kit have the choice. But for normal distribution I totally understand. |
We will most likely do a major somewhen this year, but it hasn't been planned yet. But updating all dependencies to newer versions will be a part of it anyway, so I'll close this issue for now. |
Okay, please ping me or check out the patches folder on Debian as the work is maybe already done and can be imported |
Hi @sgiehl
On Debian I upgraded Monlog to v2 and then v3
See (v2): https://sources.debian.org/src/matomo/5.2.2%2Bdfsg-1/debian/patches/0006-Upgrade-monolog-to-v2.patch/
See (v3): https://sources.debian.org/src/matomo/5.2.2%2Bdfsg-1/debian/patches/0028-Upgrade-monolog-to-v3.patch/
I think I will do a PR for v2 since it is PHP 7.2 compatible: https://github.com/Seldaek/monolog/blob/2.x/composer.json#L16
The text was updated successfully, but these errors were encountered: