Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the mixin to the bower repository #17

Closed
kitze opened this issue Nov 21, 2014 · 8 comments
Closed

Add the mixin to the bower repository #17

kitze opened this issue Nov 21, 2014 · 8 comments

Comments

@kitze
Copy link

kitze commented Nov 21, 2014

Can you please do this? If you can't do it can i upload it on my own bower repo for sass mixins (i'll add reference to your name, copyright and everything) because it's painful to download and insert manually from github into every new project :)

@mhulse
Copy link
Contributor

mhulse commented Nov 21, 2014

Hi @rokerot,

For now, you can always grab from GitHub directly (just tested and it works):

{
  "name": "bower",
  "dependencies": {
    "sass-flex-mixin": "https://github.com/mastastealth/sass-flex-mixin.git"
  }
}

Unfortunately, fwik, you'll only be able to grab from the master's head without a release and a bower.json file.

With that said, here's the template I like to include in my repos:

{
  "name": "sass-flex-mixin",
  "version": "1.0.0",
  "main": [
    "flex.scss"
  ],
  "ignore": [
    "tests",
    "**/.*",
    "**/*.md",
    "**/*.json"
  ],
  "dependencies": {},
  "devDependencies": {},
  "keywords": [
    "sass",
    "css"
  ]
}

If we put the above at the root of this repo, and then @mastastealth published a tag/release (with whatever version number we're on … I'd say, since no versions currently exist, just roll with 1.0.0), then that would make life easier on all of us Bower users. 😄

From there, someone could publish to bower's directory, but that's optional IMHO, considering that pulling from GitHub is easy … For example, here's how you can target a version number range:

"harmonia": "https://github.com/mhulse/jquery-harmonia.git#v1",

👍

@kitze
Copy link
Author

kitze commented Nov 21, 2014

Thanks but i wanted to have it as a proper bower repo because i'm using gulp and it concats all my bower dependencies (which have a bower.json file and main : {} inside them) and if i just point it at a github repo it won't include the script in my build ... Maybe it will if you upload a bower.json file to the repo :)

@mhulse
Copy link
Contributor

mhulse commented Nov 21, 2014

I just made a PR: #18

If that's merged, then all we @mastastealth needs to do is create a release/tag named v1.0.0. :octocat:

@mastastealth
Copy link
Owner

@mhulse Thanks! Hopefully I did everything right, PR merge + release 1.0.0 added.

@mhulse
Copy link
Contributor

mhulse commented Nov 21, 2014

@mhulse Thanks! Hopefully I did everything right, PR merge + release 1.0.0 added.

Awesome! After a cursory test it works for me. Thanks @mastastealth! 👍 :octocat:

@kitze
Copy link
Author

kitze commented Dec 26, 2014

The project still doesn't exist in the bower repository :/

If you search for it there is some other flex mixinS plugin, but not yours.

http://bower.io/search/?q=sass-flex-mixin

@mastastealth mastastealth reopened this Dec 26, 2014
@mastastealth
Copy link
Owner

You're right @kitze , sorry about that. The ticket is for being in the bower repo, not simply being bower ready. I'll try adding it later today!

@mastastealth
Copy link
Owner

@kitze Ok, so I don't see it in the search from bower.io, however I did register it and doing a bower install sass-flex-mixin seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants