Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry intermittant failures on reinstated tests #3584

Closed
Ben-PH opened this issue Feb 17, 2023 · 0 comments
Closed

retry intermittant failures on reinstated tests #3584

Ben-PH opened this issue Feb 17, 2023 · 0 comments
Assignees
Labels
tests Issues related to testing the node

Comments

@Ben-PH
Copy link
Contributor

Ben-PH commented Feb 17, 2023

some tests were reinstated in #3507

the reinstated tests occassionally fail for reasons outside the scope of what is being tested (#3509) . This is handled in CI through our use of cargo nextest with automatic retries, but locally, you could run into some false fails.

Until I find an upstream fix (i.e. you can run cargo test -F testing, and things just work), the downstream sollution is to retry those tests manually, or use nextest run --retries 5.

A intermittant fix should allow cargo test to run nextest run --retries 5

@Ben-PH Ben-PH added the tests Issues related to testing the node label Feb 17, 2023
@Ben-PH Ben-PH self-assigned this Feb 17, 2023
@AurelienFT AurelienFT mentioned this issue Feb 23, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues related to testing the node
Projects
None yet
Development

No branches or pull requests

2 participants