Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[follow-up #3846] Restructure pool-tests #3506

Closed
4 of 5 tasks
Ben-PH opened this issue Feb 6, 2023 · 1 comment · Fixed by #3507
Closed
4 of 5 tasks

[follow-up #3846] Restructure pool-tests #3506

Ben-PH opened this issue Feb 6, 2023 · 1 comment · Fixed by #3507
Assignees

Comments

@Ben-PH
Copy link
Contributor

Ben-PH commented Feb 6, 2023

#3486 re-instates some pool tests, but there are some refinements that would be nice to add:

  • re-use of the mock provider function for get_block_operations
  • use of pool_test function in the test_pool test
  • re-use of the thread setup in test_pool test
  • Clear less than helpful renames
  • confirm no remaining ignored tests
@Ben-PH Ben-PH self-assigned this Feb 6, 2023
@Ben-PH Ben-PH mentioned this issue Feb 7, 2023
7 tasks
@Ben-PH Ben-PH linked a pull request Feb 7, 2023 that will close this issue
7 tasks
@Ben-PH
Copy link
Contributor Author

Ben-PH commented Feb 7, 2023

Duplicated code segments I've found:

pub fn create_operation_with_expire_period(

pub fn create_operation_with_expire_period(

...if you follow where each of these methods are called from, protocol impl has maaaaaany call locations. Could look at them to see how things can be DRY'd up

@Ben-PH Ben-PH closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant