Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeWeb Smart-Contract Wrapper #720

Open
4 tasks
pivilartisant opened this issue Dec 23, 2024 · 6 comments
Open
4 tasks

Add DeWeb Smart-Contract Wrapper #720

pivilartisant opened this issue Dec 23, 2024 · 6 comments
Assignees

Comments

@pivilartisant
Copy link
Collaborator

pivilartisant commented Dec 23, 2024

Proposition: Add a Deweb smart contract wrapper (and other things) to Massa Web3

Objective:

  • create a central access point to DeWeb (and DeWeb related smart contracts) to make it easier for devs to access and use DeWeb smart contract.
  • have less and cleaner deweb related imports in project

Technical blockers:

  • should be none, all the functions have been implemented at least once... we might need to do some thinking around meta data but that is to be determined.

Deweb:

  • Export key utils
  • Create a wrapper that can be used as such : DEWEB.UploadFilesInit(...) wrapper functions should include the ones listed here
  • Export of the commun deweb models

Index:

  • Export of indexer address + add function that returns address depending on a networkparam
@pivilartisant pivilartisant self-assigned this Dec 23, 2024
@SlnPons
Copy link

SlnPons commented Jan 3, 2025

@damip could you check this issue? I'm confused about terminology here: DeWeb SC already exist. Maybe I don't get the point sorry :/

@pivilartisant
Copy link
Collaborator Author

pivilartisant commented Jan 3, 2025

@damip could you check this issue? I'm confused about terminology here: DeWeb SC already exist. Maybe I don't get the point sorry :/

sorry @SlnPons i meant smart-contract wrapper... just some code to make it easier for devs to use and call sc functions

@SlnPons SlnPons added the P1 label Jan 3, 2025
@SlnPons SlnPons assigned SlnPons and Ben-Rey and unassigned SlnPons Jan 3, 2025
@Ben-Rey Ben-Rey added the question Further information is requested label Jan 7, 2025
@Ben-Rey
Copy link
Collaborator

Ben-Rey commented Jan 7, 2025

Can we clarify this need ? I propose to start with what's needed right now and why. Then we will add functionalities incrementally as needed.

@pivilartisant pivilartisant self-assigned this Jan 7, 2025
@pivilartisant
Copy link
Collaborator Author

Can we clarify this need ? I propose to start with what's needed right now and why. Then we will add functionalities incrementally as needed.

As suggested, we'll start by adding the meta-data (read and write) then determine how we proceed

@Ben-Rey Ben-Rey removed their assignment Jan 8, 2025
@SlnPons SlnPons removed question Further information is requested P1 labels Jan 14, 2025
@SlnPons
Copy link

SlnPons commented Jan 16, 2025

@pivilartisant @thomas-senechal for this issue to be prioritised correctly, it would be good to order the list of needs listed above.
It would be too much time consuming to do everything at once. Let's try to break it down for now. Could you have a try to priorise it (and/or discuss it with Pierre for instance)?

@pivilartisant
Copy link
Collaborator Author

@pivilartisant @thomas-senechal for this issue to be prioritised correctly, it would be good to order the list of needs listed above. It would be too much time consuming to do everything at once. Let's try to break it down for now. Could you have a try to priorise it (and/or discuss it with Pierre for instance)?

hey @SlnPons https://github.com/massalabs/deweb-uploader/pull/31 this pull request (refactor) should pave the way and provide some clarity for other developers. IMO, once it is merged, this can be re-evaluated and discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants