Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages & error handling #165

Open
3 tasks
SlnPons opened this issue Nov 14, 2024 · 4 comments
Open
3 tasks

Improve error messages & error handling #165

SlnPons opened this issue Nov 14, 2024 · 4 comments

Comments

@SlnPons
Copy link
Collaborator

SlnPons commented Nov 14, 2024

Objective
Make sure that errors messages displayed to end-users are clear enough for them to solve the problem or to share a meaningful screenshot to the team.

How to

  • List all existing error messages
  • Write clear and simple messages to display
  • Implement new error messages
@SlnPons
Copy link
Collaborator Author

SlnPons commented Jan 2, 2025

@pivilartisant how do we manage the error and error messaging on deweb V1 please?

@pivilartisant
Copy link
Collaborator

@pivilartisant how do we manage the error and error messaging on deweb V1 please?

This concerns the CLI app mainly, but the error is outputed to the terminal and stops the program. error can be copied and pasted to discord channel for support.

@SlnPons
Copy link
Collaborator Author

SlnPons commented Jan 2, 2025

Thanks so the front-end is using the error messages coming from the CLI directly?

@thomas-senechal could you elaborate on how the error are managed on the CLI side? Do you have an error file that Lucas and I can modify or sth easily editable?

@pivilartisant
Copy link
Collaborator

pivilartisant commented Jan 3, 2025

Thanks so the front-end is using the error messages coming from the CLI directly?

@thomas-senechal could you elaborate on how the error are managed on the CLI side? Do you have an error file that Lucas and I can modify or sth easily editable?

Not technically, error on cli and front end are the same when it comes from the node.

On front-end side, wallet errors are displayed "as is" and user can take screenshots

Specifically on cli side, there are errors (wrong password, invalid keypair) that are handled and explicit for user

I believe it would be out of reach to make errors user-friendly at this level because it's node and wallet things that we do not always control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants