Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong project version in 2.4.0 release #110

Closed
GiulioRomualdi opened this issue Aug 11, 2021 · 3 comments
Closed

Wrong project version in 2.4.0 release #110

GiulioRomualdi opened this issue Aug 11, 2021 · 3 comments
Labels
bug Something isn't working cmake Issues relating to cmake.

Comments

@GiulioRomualdi
Copy link
Contributor

I noticed that in the release 2.4.0 the cmake project version is 2.3.1

project(tomlplusplus LANGUAGES CXX VERSION 2.3.1)

This is actually a problem when cmake find_package method is used in a consumer library.

Indeed

find_package(tomlplusplus 2.4.0 REQUIRED)

will fail with an error similar to this one

  Could not find a configuration file for package "tomlplusplus" that is
  compatible with requested version "2.4.0".

  The following configuration files were considered but not accepted:

    /usr/share/miniconda/envs/test/lib/cmake/tomlplusplus/tomlplusplusConfig.cmake, version: 2.3.1

On the latest master 4f21332 the version is correct

@marzer
Copy link
Owner

marzer commented Aug 11, 2021

Ah, thanks for reporting this @GiulioRomualdi. There have been a few other minor useful improvements since 2.4.0 too so perhaps it's time for me to publish a new release.

@marzer marzer added bug Something isn't working cmake Issues relating to cmake. labels Aug 11, 2021
@marzer
Copy link
Owner

marzer commented Aug 11, 2021

Released in v2.5.0 :)

@marzer marzer closed this as completed Aug 11, 2021
@traversaro
Copy link

Thanks @marzer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmake Issues relating to cmake.
Projects
None yet
Development

No branches or pull requests

3 participants