-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathological input causes crash in toml::v2::impl::ex::parser::parse_value #100
Comments
Wow, that file is nothing if not pathological. The parser uses recursive descent; input like that will cause a stack overflow. How did you come to use this input? Was it real, or from something like a fuzzer? |
Oh, never mind, I just did a quick scan of your profile; I'm going to guess it was from fuzzing :) Welp, guess I better put some pathological case detection into the parser's descent logic... thanks for the report! |
You're welcome, the input was derived from an actual file, but after about 10 million iterations it's no longer recognizable. We found a few bugs in similar parsers, so we wanted to cover all of the more popular packages like yours too. |
Awesome work! Also, turns out this actually exposed two bugs:
What fun :D |
Fixed in master. Thanks again @geeknik! |
Fix confirmed. Will let you know if we encounter anything more serious. 👍🏻 |
Whilst experimenting with the example
toml_to_json_transcoder
built from commitdca694
, we discovered a file which triggers a segfault:crash.zip
The text was updated successfully, but these errors were encountered: