-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoreFX implications #8
Comments
Started work on v2.0 based on RC2. Very early days, but some design notes...
|
https://github.com/martinjw/dbschemareader/releases/tag/2.0.0 Merge into master this weekend. |
Documentation on netstandard: https://dbschemareader.codeplex.com/wikipage?title=NetStandard |
Merged, pushed to Codeplex mirror and Nuget. To do:
|
Visual Studio 2017 is released March 7 2017. Next step is to upgrade the DatabaseSchemaReaderCore.sln/projects to VS2017 csproj format. Existing non-core project will probably be named "DatabaseSchemaReader2015.sln". |
For my reference... Trial conversion with Visual Studio 2017RC works. "dotnet build" command line fails for .net 3.5 because of this issue: For command line, the full msbuild works (only the 2017 version, obviously; this must be what VS uses) Will redo when I have the VS2017 RTM. |
VS2017/Core+multi-targeting version added (solution DatabaseSchemaReader.sln) Appveyor now has VS2017 image, but no database services, so build is still failing. Just waiting on appveyor now... |
Do you have any updates? |
Core/netstandard 1.5 is working fine Core/netstandard 2.0 just added (yesterday...). Shortly I will enable some of the excluded features (reading data, stored procedures). The invocation will remain different between core and full framework. DbProviderFactories doesn't exist in netstandard 2 due to the completely different configuration model (although there is a stub DbProviderFactory). |
Thanks, sounds good. |
Support for both netstandard 1.5 and extra APIs for netstandard 2.0 |
CoreFX won't have DataTables, but they are replacing DbConnection.GetSchema which is the core of dbSchemaReader.
CoreFX issue: https://github.com/dotnet/corefx/issues/3423
and https://github.com/dotnet/corefx/issues/5024
The current proposal looks like our data schema model, which is promising. This library could then depend on the CoreFx model and schema reading (a more solid base than the existing GetSchema datatables).
We'll see what the final version looks like before deciding whether we wrap it with our model, or extend their model. Whichever, this library could potentially be a good bridge to support both older full framework and CoreFx.
Not looking forward to the conditional compilation directives though.
The text was updated successfully, but these errors were encountered: