Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] WingetUI does not report GodotEngine.GodotEngine as upgradeable, but Winget does #1519

Closed
4 tasks done
kriswilk opened this issue Oct 23, 2023 · 8 comments
Closed
4 tasks done
Assignees
Labels
bug Something isn't working needs-author-answer

Comments

@kriswilk
Copy link

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have tested that this issue has not been fixed in the latest (beta or stable) release.
  • I have checked the FAQ section for solutions
  • This issue is about a bug (if it is not, please use the correct template)

Describe your issue

Winget CLI reports that GodotEngine.GodotEngine is upgradeable from v4.1.1 to v4.1.2. However, WingetUI does not list this package as one of the available upgrades. It appears that WingetUI's call to winget does not list the package for some reason??

Steps to reproduce the issue

  • run "winget upgrade" to enumerate upgradable packages (see screenshot)
  • refresh WingetUI software updates list (see screenshot)
  • compare the results

WingetUI Log

🔵 Loading WingetUI log...
🔵 Sending cancel signal...
🔵 Reloading sources...
🔵 Reloading Winget sources...
🟢 Searching for string ""
🔵 Reloading Scoop sources...
🔵 Starting Winget search for updates
🟢 Winget search for updates finished with 5 result(s)
🟢 Searching for string ""
🟢 Searching for string ""
🟡 Can't get custom interval time! (got value was '')
🟢 Total packages: 5
🔵 Loading WingetUI log...

Package Managers Logs

- 
   \ 
                                                                                                                        

  ███▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  1024 KB / 8.20 MB
  ███████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  2.00 MB / 8.20 MB
  ██████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  3.00 MB / 8.20 MB
  ██████████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  4.00 MB / 8.20 MB
  ██████████████████▒▒▒▒▒▒▒▒▒▒▒▒  5.00 MB / 8.20 MB
  █████████████████████▒▒▒▒▒▒▒▒▒  6.00 MB / 8.20 MB
  █████████████████████████▒▒▒▒▒  7.00 MB / 8.20 MB
  █████████████████████████████▒  8.00 MB / 8.20 MB
  ██████████████████████████████  8.20 MB / 8.20 MB
                                                                                                                        

   - 
                                                                                                                        
Name                                                        Id                          Version    Available  Source
--------------------------------------------------------------------------------------------------------------------
Rclone                                                      Rclone.Rclone               1.64.0     1.64.2     winget
Microsoft Visual C++ 2010  x86 Redistributable - 10.0.30319 Microsoft.VCRedist.2010.x86 10.0.30319 10.0.40219 winget
Prowlarr version 1.8.6                                      TeamProwlarr.Prowlarr       1.8.6      1.8.6.3946 winget
Radarr version 4.7.5                                        TeamRadarr.Radarr           4.7.5      5.0.3      winget
Lidarr version 1.3.5                                        TeamLidarr.Lidarr           1.3.5      1.3.5.3530 winget
5 upgrades available.

Relevant information

No response

Screenshots and videos

image

image

@kriswilk kriswilk added the bug Something isn't working label Oct 23, 2023
@marticliment
Copy link
Owner

Hello @kriswilk,

WingetUI's winget does not seem to be detecting GodotEngine.

Which winget version are you running on the system? Which WingetUI version?
Have you tried forcing a reload of the winget sources via winget update, using wingetui's bundled winget?

@kriswilk
Copy link
Author

winget version reported at CLI: v1.7.2782-preview
WingetUI version: 2.1.1

Interestingly, WingetUI about box indicates winget "found" at version 1.6.2771. I'm guessing this is part of the problem. Does WingetUI bundle its own version of winget? I don't know how I could possibly have two versions. It's a new PC running Windows 11 with all updates. No insider previews or anything strange.

image

@kriswilk
Copy link
Author

As a follow-up...I just looked in WingetUI settings and see that yes, you do bundle your own copy of winget (why...is this so users don't even need to install winget in the first place?). I tried clicking the "reset winget sources" button and then refreshed the package list, but nothing changed.

@marticliment
Copy link
Owner

is this so users don't even need to install winget in the first place?

No, this is to prevent winget localisation from breaking parsing mechanisms. The bundled version of winget does not include translation files.

I tried clicking the "reset winget sources" button and then refreshed the package list, but nothing changed.

On my WingetUI install I can see godot version 4.1.2 showing up (running on winget 1.6), so winget or wingetui themselves are not the cause.
Winget 1.6 involves a new feature named package list caching to prevent winget server overloading, so your installation might just be waiting for a timeout before truly fetching the package indexes (despite you calling winget update.) You can read more about that change here: microsoft/winget-cli#3718

@kriswilk
Copy link
Author

kriswilk commented Oct 25, 2023

It's been days without change. I don't think that has anything to do with this. To test further, I used Terminal to run the WingetUI-bundled winget to show me package info for Godot:

PS C:\Program Files\WingetUI\PackageManagers\winget-cli_x64> .\winget show godotengine.godotengine
Found Godot Engine [GodotEngine.GodotEngine]
Version: 4.1.2
Publisher: Godot Engine
Publisher Url: https://godotengine.org
Publisher Support Url: https://github.com/godotengine/godot/issues
Description: Multi-platform 2D and 3D game engine
Homepage: https://github.com/godotengine/godot
License: MIT License
License Url: https://github.com/godotengine/godot/blob/master/LICENSE.txt
Release Notes:
  - Release notes
  - Curated changelog
  - Download (GitHub): Expand Assets below
Release Notes Url: https://github.com/godotengine/godot/releases/tag/4.1.2-stable
Installer:
  Installer Type: portable (zip)
  Installer Url: https://github.com/godotengine/godot/releases/download/4.1.2-stable/Godot_v4.1.2-stable_win64.exe.zip
  Installer SHA256: 4bcc449aae8ea10280e2bf2be3da02f7da6b86f3265d337428e847e0ecd8704d
  Release Date: 2023-10-04
PS C:\Program Files\WingetUI\PackageManagers\winget-cli_x64>

As you can see, WingetUI's version of winget clearly knows about the new version 4.1.2. Yet using it to run winget upgrade yields:

PS C:\Program Files\WingetUI\PackageManagers\winget-cli_x64> .\winget upgrade
Name                                                        Id                          Version       Available      Source
---------------------------------------------------------------------------------------------------------------------------
Rclone                                                      Rclone.Rclone               1.64.0        1.64.2         winget
Microsoft Visual C++ 2010  x86 Redistributable - 10.0.30319 Microsoft.VCRedist.2010.x86 10.0.30319    10.0.40219     winget
Prowlarr version 1.8.6                                      TeamProwlarr.Prowlarr       1.8.6         1.8.6.3946     winget
Google Chrome                                               Google.Chrome               118.0.5993.89 118.0.5993.118 winget
Radarr version 4.7.5                                        TeamRadarr.Radarr           4.7.5         5.0.3          winget
Lidarr version 1.3.5                                        TeamLidarr.Lidarr           1.3.5         1.3.5.3530     winget
6 upgrades available.
PS C:\Program Files\WingetUI\PackageManagers\winget-cli_x64>

Lastly, I made sure WingetUI's winget knew that Godot 4.1.1 was already installed:

Name                                           Id                                                            Version          Source
-------------------------------------------------------------------------------------------------------------------------------------
<other items clipped for brevity>
Beyond Compare 4.4.6                           ScooterSoftware.BeyondCompare4                                4.4.6.27483      winget
Microsoft Clipchamp                            Clipchamp.Clipchamp_yxz26nhyzhsrt                             2.8.1.0
Colors                                         den4b.Colors                                                  3.1.0.0          winget
FreeCAD 0.21.1 (Installed for Current User)    FreeCAD.FreeCAD                                               0.21.1           winget
GIMP 2.10.34-2                                 GIMP.GIMP                                                     2.10.34          winget
Git                                            Git.Git                                                       2.42.0.2         winget
Godot Engine                                   GodotEngine.GodotEngine_Microsoft.Winget.Source_8wekyb3d8bbwe 4.1.1
HWiNFO64 Version 7.64                          REALiX.HWiNFO                                                 7.64             winget
Hack Fonts version 1.6.0                       SourceFoundry.HackFonts                                       1.6.0            winget
Hasher                                         den4b.Hasher                                                  4.1.0.0          winget
<other items clipped for brevity>
PS C:\Program Files\WingetUI\PackageManagers\winget-cli_x64>

On one hand, winget knows what version is installed AND knows that there is a new version. On the other hand, it's not offering to upgrade it.

I realize WingetUI is just acting on the results of this bundled winget, but if it's happening to me, who knows what other packages are affected.

Ideas??


EDIT: Just noticed in the winget list output that the package name is GodotEngine.GodotEngine_Microsoft.Winget.Source_8wekyb3d8bbwe. I think this is because it's a ZIP install, so winget does something funky to track it? Maybe that's why it's not being picked up by WingetUI's winget? I installed it originally just by using:

winget install -e --id "GodotEngine.GodotEngine"

@marticliment
Copy link
Owner

I don't know why Godot is being reported as GodotEngine.GodotEngine_Microsoft.Winget.Source_8wekyb3d8bbwe, but this is likely the cause of thisissue, since the available package from the repo is "GodotEngine.GodotEngine", and GodotEngine.GodotEngine is detected as v4.1.2.

Please try installing GodotEngine 4.1.2 from WingetUI (or from bundled winget) to force an update, and post back which package id is and version are reported on the InstalledPackages tab.

@kriswilk
Copy link
Author

kriswilk commented Oct 25, 2023

Well, I went ahead and did what you said, and now the package is listed as GodotEngine.GodotEngine, at version 4.1.2. Very strange.

As an experiment, I uninstalled, then reinstalled using the system winget and forcing version 4.1.1 using --version 4.1.1. It, too, just showed the package as GodotEngine.GodotEngine. WingetUI upgraded that just fine.

I have NO IDEA why the package was listed as GodotEngine.GodotEngine_Microsoft.Winget.Source_8wekyb3d8bbwe before, because I installed it in the exact same way.

This leaves me with an uneasy feeling, makes me wonder when it will happen again, and if I can really expect WingetUI to present the correct list of updates. I only noticed because I happened to run winget upgrade at the command line.

Not sure if this closes the issue...if you decide to close it, please keep it in mind should similarly strange behaviour be reported.

EDIT: I should also add, thanks for your help and suggestions!

@marticliment
Copy link
Owner

I will close this, since it is an issue that happened one time only, and also since this is ultimately a winget bug, not a WingetUI one.

However, if more cases of this issue appear i'll reopen it.
If you happen to experience it again, please let me know

@marticliment marticliment closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-author-answer
Projects
None yet
Development

No branches or pull requests

2 participants