Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console warning when using alwaysOn ReferenceInput in Filter component #4133

Closed
MiMo42 opened this issue Dec 10, 2019 · 1 comment · Fixed by #4139
Closed

Console warning when using alwaysOn ReferenceInput in Filter component #4133

MiMo42 opened this issue Dec 10, 2019 · 1 comment · Fixed by #4139
Labels

Comments

@MiMo42
Copy link
Contributor

MiMo42 commented Dec 10, 2019

What you were expecting:
No console warnings

What happened instead:
Console warning:
Warning: React does not recognize the alwaysOn prop on a DOM element.
It hit me after set alwaysOn prop on a ReferenceInput within a Filter component.

Steps to reproduce:

Related code:
https://codesandbox.io/s/simple-ciybl

Other information:
I only had the time to do some short investigation.
It looks like alwaysOn prop is actually not sanitized, although there is a dedicated sanitizeRestProps in FilterFormInput. The alwaysOn flag is transferred to children of FilterFormInput and applied to DOM elements further down.

Environment

  • React-admin version: 3.0.3
  • React version: 16.12.0
  • Browser: Chrome
@Kmaschta Kmaschta added the bug label Dec 10, 2019
@Kmaschta
Copy link
Contributor

Reproduced, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants