Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full TitleConfiguration #65

Closed
RestoreMonarchy opened this issue Dec 30, 2019 · 6 comments · Fixed by #67
Closed

Add full TitleConfiguration #65

RestoreMonarchy opened this issue Dec 30, 2019 · 6 comments · Fixed by #67
Labels
enhancement New feature or request

Comments

@RestoreMonarchy
Copy link

I'd like to suggest to add full OptionsTitle support, so I can change a Title color.
Default color looks bad on within theme and I can't change it with css.

https://www.chartjs.org/docs/latest/configuration/title.html

Thank You!

@RestoreMonarchy RestoreMonarchy added the enhancement New feature or request label Dec 30, 2019
@Joelius300
Copy link
Contributor

Thanks for contacting us!

Good idea, crazy how we haven't done that yet :)
I'll look into it unless you want to do it yourself in which case, please tell us.

@RestoreMonarchy
Copy link
Author

RestoreMonarchy commented Dec 30, 2019

I'll have a look and try then make pull request. If I won't it will mean I couldn't.
Is it actually enough to just add properties?

@Joelius300
Copy link
Contributor

Joelius300 commented Dec 30, 2019

Yes it should be enough to just add the properties (and possible change a demo or two to showcase it). I'm actually already done pretty much (I was already working on something) so unless you've already started, I'll just submit mine 😅

@RestoreMonarchy
Copy link
Author

Oh well I did it too, but I'll still make a pull request, so just reject it if you already made it

@RestoreMonarchy
Copy link
Author

Thank you for quick response! I willl close issue now.

@Joelius300
Copy link
Contributor

It's been merged to master. I don't know how long it will take for the nuget to be updated. If you need the changes right now, you might need to build our library from the sources.
I hope you understand :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants