Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autotroph_secondary_species is intent(out) rather than intent(inout) #312

Closed
mnlevy1981 opened this issue Aug 24, 2018 · 1 comment
Closed

autotroph_secondary_species is intent(out) rather than intent(inout) #312

mnlevy1981 opened this issue Aug 24, 2018 · 1 comment
Assignees
@mnlevy1981
Milestone
MARBL1.0.0

Comments

@mnlevy1981
Copy link
Collaborator

This occurs in three subroutine in marbl_mod.F90:

  • marbl_compute_Pprime
  • marbl_compute_autotroph_uptake
  • marbl_compute_autotroph_nfixation

Hopefully we are getting lucky, and the compilers (esp at non-DEBUG optimization levels) are treating these as (inout) anyway. If that's the case, this won't change answers and should go in ASAP. If it does change answers, I think that means it's relegated to post-CESM 2.1?
@mnlevy1981 mnlevy1981 added this to the MARBL1.0.0 milestone Aug 24, 2018
@mnlevy1981 mnlevy1981 self-assigned this Aug 24, 2018
@mnlevy1981
Copy link
Collaborator Author

This was fixed by #318 but never closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnlevy1981 mnlevy1981

Labels
None yet
Projects
None yet
Milestone
MARBL1.0.0
Development

No branches or pull requests
1 participant
@mnlevy1981